How to stop double rendering in sidebar?

Question

The code is double rendering like so:

when it should just list it out once like so:

Ran 1 miles Apr 
Journal 1 days Apr

views/layouts/_stats.html.erb

<% @averaged_quantifieds.each do |averaged| %>
<% averaged.results.each do |result| %>
  <div class="<%= result.good? ? 'green' : 'red' %>">
    <li>
      <%= raw averaged.tag_list.map { |t| link_to t.titleize, tag_path(t) }.join(', ') %><%= link_to edit_quantified_path(averaged) do %> <%= averaged.results.first.result_value %> <%= averaged.metric %> <span class="<%= date_value_label_class(result) %>"> <%= averaged.results.first.date_value.strftime("%b") %></span><% end %>
    </li>
  </div>
<% end %>
<% end %>

application_controller

def set_stats
  @averaged_quantifieds = current_user.quantifieds.averaged if current_user
  @instance_quantifieds = current_user.quantifieds.instance if current_user
end

Results are a nested_attribute to Quantifieds.

quantifieds_controller

class QuantifiedsController < ApplicationController
  before_action :set_quantified, only: [:show, :edit, :update, :destroy]
  before_action :logged_in_user, only: [:create, :destroy]

  def index
    if params[:tag]
      @quantifieds = Quantified.tagged_with(params[:tag])
    else
      @quantifieds = Quantified.joins(:results).all
      @averaged_quantifieds = current_user.quantifieds.averaged
      @instance_quantifieds = current_user.quantifieds.instance
    end
  end

  def show
  end

  def new
    @quantified = current_user.quantifieds.build 
  end

  def edit
  end

  def create
    @quantified = current_user.quantifieds.build(quantified_params)
    if @quantified.save
      redirect_to quantifieds_url, notice: 'Quantified was successfully created'
    else
      @feed_items = []
      render 'pages/home'
  end
end

  def update
    if @quantified.update(quantified_params)
      redirect_to quantifieds_url, notice: 'Goal was successfully updated'
    else
      render action: 'edit'
  end
end

  def destroy
    @quantified.destroy
    redirect_to quantifieds_url
  end

  private
    def set_quantified
      @quantified = Quantified.find(params[:id])
    end

    def correct_user
      @quantified = current_user.quantifieds.find_by(id: params[:id])
      redirect_to quantifieds_path, notice: "Not authorized to edit this goal" if @quantified.nil?
    end

    def quantified_params
      params.require(:quantified).permit(:categories, :metric, :date, :comment, :private_submit, :tag_list, results_attributes: [:id, :result_value, :date_value, :good, :_destroy])
    end
end

quantified.rb

    class Quantified < ActiveRecord::Base
        belongs_to :user
        has_many :results #correct
        has_many :comments, as: :commentable
        accepts_nested_attributes_for :results, :reject_if => :all_blank, :allow_destroy => true #correct
        scope :averaged,  -> { where(categories: 'Averaged') }
        scope :instance,  -> { where(categories: 'Instance') }
        scope :private_submit, -> { where(private_submit: true) }
        scope :public_submit, -> { where(private_submit: false) }
        validates :categories, :metric, presence: true
        acts_as_taggable

        CATEGORIES = ['Averaged', 'Instance']
    end

result.rb

    class Result < ActiveRecord::Base
        belongs_to :user
      belongs_to :quantified
        has_many :comments, as: :commentable
      default_scope { order('date_value DESC') }
        scope :good, -> { where(good: true) }
        scope :good_count, -> { good.count }
    end

The issue came about when trying to introduce differing font colors for results. To make that possible I had to introduce these two lines which are causing the double rendering: <% averaged.results.each do |result| %> <div class="<%= result.good? ? 'green' : 'red' %>">

Thank you for your time and expertise.

Answer 1

You should explain more about the logic and the data stored.

A guess is that there's two records in @averaged_quantifieds and three in averaged.results. It is hard to determine the desired results without knowing the data stored.

Note that you are only displaying the firsts records results (averaged.results.first) in the <%= raw ... line

Try

<% @averaged_quantifieds.each do |averaged| %>

  <div class="<%= averaged.results.first.good? ? 'green' : 'red' %>">
    <li>
      <%= raw averaged.tag_list.map { |t| link_to t.titleize, tag_path(t) }.join(', ') %><%= link_to edit_quantified_path(averaged) do %> <%= averaged.results.first.result_value %> <%= averaged.metric %> <span class="<%= date_value_label_class(result) %>"> <%= averaged.results.first.date_value.strftime("%b") %></span><% end %>
    </li>
  </div>

<% end %>

Edit: My bad, I missed one result object (<%= date_value_label_class(result) %>) hiding in the rest of the line

Change result to averaged.results.first wherever applicable

<% @averaged_quantifieds.each do |averaged| %>
  <div class="<%= averaged.results.first.good? ? 'green' : 'red' %>">
    <li>
      <%= raw averaged.tag_list.map { |t| link_to t.titleize, tag_path(t) }.join(', ') %><%= link_to edit_quantified_path(averaged) do %> <%= averaged.results.first.result_value %> <%= averaged.metric %> <span class="<%= date_value_label_class(averaged.results.first) %>"> <%= averaged.results.first.date_value.strftime("%b") %></span><% end %>
    </li>
  </div>
<% end %>