Is this a correct UML activity diagram?

Question

Made this diagram for my tictactoe game. It is an activity diagram here is a link: http://i58.tinypic.com/fo26n4.png tell me if it is correct. Thanks

• Is it correct?

• What am i doing wrong?

Answer 1

No. The problems are:

• you haven't created the loop for each move.
• Put there a switch X-O for every turn
• Tie a player to X and to O.
• Check winner sounds strange. Look for three in line would be better.
• Add declare current player as a winner.