When determining whether or not a file exists, how does using the try statement avoid a "race condition"?
I'm asking because a highly upvoted answer (update: it was deleted) seems to imply that using os.path.exists()
creates an opportunity that would not exist otherwise.
The example given is:
try:
with open(filename): pass
except IOError:
print 'Oh dear.'
But I'm not understanding how that avoids a race condition compared to:
if not os.path.exists(filename):
print 'Oh dear.'
How does calling os.path.exists(filename)
allow the attacker to do something with the file that they could not already do?
I think what you're asking is the particular race condition where:
The way you're "protected" in this case is by putting all the file handling code in a
try
block, if at any point the file becomes inaccessible/corrupt your file operations will be able to fail "gracefully" via thecatch
block.Note of course modern OS's this can't happen anyway, when a file is "deleted" the delete won't take place until all open handles on the file are resolved (released)
Here's an example of usage:
If you are opening the file with any access at all, then the OS will guarantee that the file exists, or else it will fail with an error. If the access is exclusive, any other process in contention for the file will either be blocked by you, or block you.
The
try
is just a way to detect the error or success of the act of opening the file, since file I/O APIs in Python typically do not have return codes (exceptions are used instead). So to really answer your question, it's not thetry
that avoids the race condition, it's theopen
. It's basically the same in C (on which Python is based), but without exceptions. Read this for more information.Note that you would probably want to execute code that depends on access to the file inside the try block. Once you close the file, its existence is no longer guaranteed.
Calling
os.path.exists
merely gives a snapshot at a moment in time when the file may or may not exist, and you have no knowledge of the existence of the file onceos.path.exists
returns. Malevolent code or unexpected logic may delete or change the file when you are not expecting it. It is akin to turning your head to check that a road is clear before driving into it. Once you turn your head back, you have nothing but a guess about what is going on where you are no longer looking. Holding the file open guarantees an extended consistent state, something not possible (for good or ill) when driving. :)Your suggestion of checking that a file does not exist rather than using
try/open
is still insufficient because of the snapshot nature ofos.path.exists
. Unfortunately I know of no way to prevent files from being created in a directory in all cases, so I think it is best to check for the positive existence of a file, rather than its absence.The race condition is, of course, between your program and some other code that operates on file (race condition always requires at least two parallel processes or threads, see this for details). That means using
open()
instead ofexists()
may really help only in two situations:exists()
just performs a single check. If file exists, it may be deleted a microsecond afterexists()
returnedTrue
. If file is absent, it may be created immediately.However,
open()
not just tests for file existence, but also opens the file (and does these two actions atomically, so nothing can happen between the check and the opening). Usually files can not be deleted while they are open by someone. That means that insidewith
you may be completely sure: file really exists now since it is open. Though it's true only insidewith
, and the file still may be deleted immediately afterwith
block exits, putting code that needs file to exist insidewith
guarantees that code will not fail.