tslint one line rule misplaced 'else'

2019-06-16 03:49发布

I have such config in tslint.json for one line rule

one-line": [true,
      "check-open-brace",
      "check-catch",
      "check-else",
      "check-whitespace"
    ],

When I have code lines like that:

if(SomethingTrue) { next("a"); }
else { next("b"); }

I've got warning:

(one-line) file.ts[17, 9]: misplaced 'else'

Why that is happens? Is it bad practice to have one line else?

4条回答
Anthone
2楼-- · 2019-06-16 04:08
if (condition is true) {
  // do something;
}
else {
  // do something else;
}

Notice that else comes next to }

if (condition is true) {
  // do something;
} else {
  // do something else;
}
查看更多
可以哭但决不认输i
3楼-- · 2019-06-16 04:20

According to the tslint docs the problem is that when "check-else" is specified under one-line the else must be on the same line as the closing brace for your if.

So in your case instead of:

if(SomethingTrue) { next("a"); }
else { next("b"); }

Use this format:

if(SomethingTrue) { next("a"); } else { next("b"); }
查看更多
你好瞎i
4楼-- · 2019-06-16 04:20
if (condition) {
  // Your Code
} else {
  // Your Code
}

End of If and start of else should be on the same line.

查看更多
Anthone
5楼-- · 2019-06-16 04:24

You have :

else { next("b"); }

Else must be one one line. So:

else { 
    next("b"); 
}

Is it bad practice to have one line else?

Just easier to read. Its a styleguide for consistency.

查看更多
登录 后发表回答