This is the constructor for node in list class. I need to make a deep copy of winery, an other class in the initialization list. Item is an instance of winery.
List::Node::Node(const Winery& winery) :
item(winery)
// your initialization list here
{
Winery w = winery;
item = w;
}
constructor for winery:
Winery::Winery(const char * const name, const char * const location,
const int acres, const int rating) :
name(name),
location(location),
acres(acres),
rating(rating)
{
char *nm = new char[strlen(name) + 1];
char *loc = new char[strlen(location) + 1];
strcpy(nm, this->name);
strcpy(loc, this->location);
this->name = nm;
this->location = loc;
this->acres = acres;
this->rating = rating;
}
There's absolutely no reson to copy the winery three times in the Node-ctor.
Once is enough:
You might add a move-ctor though (C++11 and later):
Similar for
Winery
.If those four are all the members, the
Winery
-ctor already does a deep-copy.I hope you remembered the rule-of-3 and also provided a custom copy-ctor, copy-assignment-operator and dtor.
Still, better would be using
std::unique_ptr
orstd::string
.Also, the top-level cv-qualifiers are useless, thus I removed them.