I want to use boost signals2 with automatic connection management in a multithreaded application. My class inherits from enable_shared_from_this<>
and i want to connect a member method from within another member method. The connection might be rebuilt frequently so my code should be as fast as possible (despite from the boost signals2 performance itself):
typedef boost::signals2::signal<void ()> signal_type;
struct Cat : public enable_shared_from_this<Cat>
{
void meow ();
void connect (signal_type& s)
{
// can't write this
s.connect (signal_type::slot_type (&Cat::meow, this, _1).track (weak_from_this ()));
// ok, but slow?! two temporary smart pointers
weak_ptr<Cat> const myself (shared_from_this ());
s.connect (signal_type::slot_type (&Cat::meow, this, _1).track (myself));
}
// i am missing something like this in the base class
// protected:
// weak_ptr<Cat> const& weak_from_this ();
};
I know that my design goals might be conflicting (automatic connection management and thread safety but also fast code) but anyway:
Why does
enable_shared_from_this<>
lack direct access to the embeddedweak_ptr<>
? I can't see an opposing reason. Is there no use case similar to mine?Is there a faster workaround than the one above?
Edit:
I know i can do somethink like this, but i want to avoid the additional storage/init-check penalty:
template <typename T>
struct enable_weak_from_this : public enable_shared_from_this<T>
{
protected:
weak_ptr<T> /* const& */ weak_from_this ()
{
if (mWeakFromThis.expired ())
{
mWeakFromThis = this->shared_from_this ();
}
return mWeakFromThis;
}
private:
weak_ptr<T> mWeakFromThis;
};
The reason you don't have access to the
weak_ptr
is thatenable_shared_from_this
doesn't have to use one. Having aweak_ptr
is simply one possible implementation ofenable_shared_from_this
. It is not the only one.Since
enable_shared_from_this
is part of the same standard library asshared_ptr
, a more efficient implementation could be used than directly storing aweak_ptr
. And the committee doesn't want to prevent that optimization.That's only one temporary smart pointer. Copy elision/movement should take care of anything but the first object.
It might be because there are no
shared_ptr
referencing theCat
instance.weak_ptr
requires there to be at least one activeshared_ptr
.Try placing a
shared_ptr
as member variable and assign to it first in theconnect
method:But basically, there can be no
weak_ptr
if there are noshared_ptr
. And if allshared_ptr
disapear while theweak_ptr
is still in use, then theweak_ptr
could point to an non-existant object.Note: My test should not be used in production code as it will cause the object to never be deallocated.