Swift random number [duplicate]

Question

This question already has an answer here:

• Crash when casting the result of arc4random() to Int 7 answers

I'm having problems with this drawRandomCard function.

It works just like it should for some time, but eventually it crashes the application.

Here is the code:

import Foundation


var cardDeck = Array<PlayingCard>()

class Deck {

    func addCard(card : PlayingCard , atTop : Bool = false){

        if atTop {
            cardDeck.insert(card, atIndex: 0);
        }else{
            cardDeck += card
        }
    }

    func drawRandomCard() -> PlayingCard{
        var card = PlayingCard()
        var randomNumber : Int = Int(arc4random()) % (cardDeck.count - 1)
        card = cardDeck[randomNumber]
        cardDeck.removeAtIndex(randomNumber)
        return card
    }

}

Answer 1

Try this: Int(rand()) instead of arc4random()

Answer 2

Use arc4random_uniform to avoid modulo bias. Like following:

let randomNumber = arc4random_uniform(150)

For your example, it will be:

let randomNumber = Int(arc4random_uniform(UInt32(cardDeck.count)))