I'm implementing a factory pattern for 3 different cryptography classes. The factory will determine which one to create and then get a serialized instance of the correct class from a database and return it to the requester.
Right now I'm working on serializing the classes to store them in the database. I'm writing one for a PGP cryptography class called BouncyCastle
. I can create the class and the keys from files but when I try to serialize it, it says that the two member variables, which are objects of class PgpPublicKey
, and PgpPrivateKey
, cannot be serialized because they do not have parameterless constructors.
public void createdBouncyFromFiles()
{
var bc = new BouncyCastle("C:\\TestFiles\\BouncyPublicKey.txt", "C:\\TestFiles\\BouncyPrivateKey.txt", "Password1");
var xmlSerializer = new XmlSerializer(bc.GetType());
var textWriter = new StringWriter();
xmlSerializer.Serialize(textWriter, bc);
var theSerializedClass = textWriter.ToString();
}
The class has two member variables that are the problem.
public class BouncyCastle : ICryptographyProvider
{
public PgpPublicKey m_publicKey;
public PgpPrivateKey m_privateKey;
public string m_passPhrase;
// cut out the irelevant parts
This is the public key class. No parameterless constructor.
public class PgpPublicKey
{
public PgpPublicKey(PublicKeyAlgorithmTag algorithm, AsymmetricKeyParameter pubKey, DateTime time);
// cut other methods
}
Any Serializer Class need a parameterless constructor because, while deserializing it create an empty new instance, then it copies every public property taken from seialized data.
You can easily make the constructor private, if you want to avoid to create it without parameters.
EX:
Yes, the XmlSerializer requires a parameterless constructor to exist in order for the serialization to work.
From the following answer: Why XML-Serializable class need a parameterless constructor
DataContractSerializer does not require parameterless constructor. What it instead requires are special attributes of class.
Are
PgpPublicKey
andPgpPrivateKey
classes defined by you? Simply add parameterless constructors to them.They can be private if you don't want to make them accessible from outside. The deserializer can still access them.