How to force validation errors update on View from

Question

I have a MVVM-based Window with many controls, and my Model implements IDataErrorInfo.

There is also a SaveCommand button, which performs validation by analysing Model.Error property.

The view displays the default red border around controls with errors only when I change the value of a particular control, or when I notify about the change of that property using PropertyChanged.

How can I force View to display all Validation errors even when I didn't touch the controls?

All my validation bindings include ValidatesOnDataErrors=True, NotifyOnValidationError=True.

I know one solution is to have an aggregate box with all the errors, but I would prefer to display errors on per-control basis.

I don't want to trigger Model.NotifyPropertyChanged for each bound property from ViewModel.

I use WPF 4.0, not Silverlight, so INotifyDataErrorInfo won't work.

Answer 1

This 'Hack' worked for me temporarily, to force the InotifyChanged event, just assign that control back it's own content. Do this before evaluating the HasError function of bindings. For example a textbox would be:

 ((TextBox)child).Text = ((TextBox)child).Text;

And then a complete example(before I hear this is not true MVVM, I directly got a handle on the grid for ease of showing this code snipet)

        public bool Validate()
    {           
        bool hasErr = false;

        for (int i = 0; i != VisualTreeHelper.GetChildrenCount(grd); ++i)
        {
            DependencyObject child = VisualTreeHelper.GetChild(grd, i);
            if (child is TextBox)
            {
                bool pp = BindingOperations.IsDataBound(child, TextBox.TextProperty);
                if (pp)
                {

                     ((TextBox)child).Text = ((TextBox)child).Text;

                    hasErr = BindingOperations.GetBindingExpression(child, TextBox.TextProperty).HasError;
                    System.Collections.ObjectModel.ReadOnlyCollection<ValidationError> errors = BindingOperations.GetBindingExpression(child, TextBox.TextProperty).ValidationErrors;
                    if (hasErr)
                    {
                        main.BottomText.Foreground = Brushes.Red;
                        main.BottomText.Text = BindingOperations.GetBinding(child, TextBox.TextProperty).Path.Path.Replace('.', ' ') + ": " + errors[0].ErrorContent.ToString();
                        return false;
                    }
                }
            }
            if (child is DatePicker)
            {
                ...                    
            }
        }

        return true;
    }

Answer 2

You mention that you don't want to raise property changed for the properties you bind to, but that's really the simplest way to accomplish this. Calling PropertyChanged with no parameter will raise for all properties in your viewmodel.

Alternatively you can update the bindings (and force revalidation) on any control like this:

myControl.GetBindingExpression(ControlType.ControlProperty).UpdateSource();

Answer 3

The best solution I've found so far that works is to change DataContext to null and back to the instance of ViewModel.

This triggers the update for controls on the view that has DataContext bound to InnerViewModel:

public void ForceUpdateErrors() {
    var tmpInnerVM = _mainViewModel.InnerViewModel;
    _mainViewModel.InnerViewModel = null;
    _mainViewModel.InnerViewModel = tmpInnerVM;
}

It's recommended to check if no data is lost after this trick. I had a case that this code triggered source update for ComboBox.SelectedItem with null but I managed to solve it. It was caused by using a resource-based BindingProxy and the order of DataContext=null propagation across control hierarchy.