I am working with jquery and attempting to add a class to a table on the selection of that table row.
I was initially using the following code -
$(this).parents("tr").toggleClass("over", this.clicked);
For some reason, that wasn't working in only some instances where there was already a class assigned. Before I went too crazy with any troubleshooting, I changed it to the following -
$(this).parents("tr").addClass("over", this.clicked);
This new option appears to be working fine.
My question is whether one option above is better than the other.....Should I be using toggleClass instead of addClass, or is addClass sufficient?
thanks for any thoughts.
There's no need to pass a second argument to .addClass() - it will always add the class.
If that's the behaviour you want, that's the right method.
If
addClass
is working for you, then you should stick with it. The methods are meant for different purposes.addClass
ensures that a particular class is present on an element, whiletoggleClass
adds the class if it isn't there and removes it if it is.Check out the API reference for the full explanation of each method:
Depends really. If you don't plan on removing the class, I'd stick with
addClass
. Naturally,toggleClass
allows you to toggle classes.addClass
does just that, adds the class to the element.toggleClass
on the other hand does THAT, toggles the class, removing it if it's there, otherwise adding it, but optionally taking a boolean value (true/false) to determine if the object should be added (true) or removed (false).toggleClass
probably wasn't working for you in the instances wherethis.clicked
wasfalse
, which is expected behavior. The argument you're passing inaddClass
has no effect, since it ALWAYS adds the class.Conclusion:
Use
toggleClass
for toggling classes, useaddClass
for adding classes.