TJson.JsonToObject throws errors in a multi-thr

Question

When using TJson.JsonToObject in a multi-thread environment random access violations occur. I was searching a long time for the problem and I could isolate it with the following code

JSON class

type
   TParameter = class
   public
      FName     : string;
      FDataType : string;
      FValue    : string;
   end;

Testfunction:

procedure Test();
var
   myTasks: array of ITask;
   i : integer;
   max : integer;
begin

  max := 50;
  SetLength(myTasks, max);
  for i := 0 to max  -1  do begin
     myTasks[i] := TTask.Create(procedure ()
       var
          json : string;
          p : TParameter;
       begin
          json := '{"name":"NameOfParam","dataType":"TypeOfParam","value":"ValueOfParam"}';
          p := TJson.JsonToObject<TParameter>(json);
          p.Free;
       end);
     myTasks[i].Start;
  end;

  TTask.WaitForAll(myTasks);
  ShowMessage('all done!');
end;

It's only a code snippet based of a much more complex source. As long I use this code in a single thread everything works without a problem. I'm wondering if there is anything wrong with the code.

Answer 1

The method TJSONUnMarshal.ObjectInstance in REST.JsonReflect.pas has a severe bug:

It calls FreeAndNil on a TRttiType instance. This should never be done because all TRtti*** instances are managed by the TRttiContext.

After I removed the FreeAndNil call I could not reproduce the access violation anymore.

Reported as: https://quality.embarcadero.com/browse/RSP-10035

P.S. I also think that https://quality.embarcadero.com/browse/RSP-9815 will affect your code.