I'm used to passing around string like this in my C++ applications:
void foo(const std::string& input)
{
std::cout << input.size() << std::endl;
}
void bar()
{
foo("stackoverflow");
}
Now I have a case where I want the string to be NULL:
void baz()
{
foo("stackoverflow");
foo(NULL); // very bad with foo implementation above
}
I could change foo
to:
void foo(const std::string* input)
{
// TODO: support NULL input
std::cout << input->size() << std::endl;
}
But to pass a string literal or copy a char*
to that implementation of foo
I need to write something like this:
void bar()
{
string input("hi"); // annoying temporary
foo(&input);
foo(NULL); // will work as long as foo handles NULL properly
}
I started thinking about inheriting from std::string
and adding a null
property, but I'm not so sure it's a good idea. Maybe it is better to simply use a const char*
string for parameters that can be NULL, but what if I want to save a copy of the string (or NULL) without having to manage its memory myself? (See What are some of the drawbacks to using C-style strings? etc.)
Any clever solution around?
Function overloading to the rescue...
This will accept both c-style char arrays and std::strings, and will incur extra overhead on the stack if you pass in a string literal or a char array, but allows you to keep your implementation in one place and keep your nice syntax.
If you want the type to be null, then make it a pointer. Pass string pointers around instead of references, since this is precisely what pointers can do, and references cant. References always point to the same valid object. Pointers can be set to null, or be reseated to point to another object. Thus, if you need the things pointers can do, use pointers.
Alternatively, use boost::optional, which allows a more type-safe way to specify "this variable may or may not contain a value".
Or, of course, change the semantics so you either use empty strings instead of null, pass a separate bool parameter specifying whether the string is available or not, or refactor so you don't need this in the first place.
Personally, I would change the semantics to pass around empty std::strings instead of NULL:
Absolutely do not inherit from
std::string
. Inheritance is the tightest coupling you can have in C++, and you're only looking for nullability, which you can get simply withconst char*
, overloads, or simplystd::string *
if you really want.Or, mixing a bit of two previous answers:
Same interface, no copy on the stack. You could, if you liked, inline fooImpl as well.
What if you just use:
Yes, this does incur an extra allocation and copy, and calling the function is a bit more verbose because you need to use
.c_str()
in the usual case, but it does give you the semantics you want.