I have the following code inside a loop statement.
In the loop, strings are appended to sb(StringBuilder) and checked whether the size of sb has reached 5MB.
if (sb.toString().getBytes("UTF-8").length >= 5242880) {
// Do something
}
This works fine, but it is very slow(in terms of checking the size)
What would be the fastest way to do this?
If you loop 1000 times, you will generate 1000String, then convert into "UTF-8 Byte" array, to get the length.
I would reduce the conversion by storing the first length. Then, on each loop, get the length of the added value only, then this is just an addition.
This would reduce the memory used and the conversion cost
Consider using a ByteArrayOutputStream and an OutputStreamWriter instead of the StringBuilder. Use ByteArrayOutputStream.size() to test the size.
You can calculate the
UTF-8
length quickly usingIf ASCII characters dominate the contents, it might be slightly faster to use
instead.
But you may also consider the optimization potential of not recalculating the entire size, but only the size of the new fragment you’re appending to the
StringBuilder
, something alikeThis assumes that if you’re appending fragments containing surrogate pairs, they are always complete and not split into their halves. For ordinary applications, this should always be the case.
An additional possibility, suggested by Didier-L, is to postpone the calculation until your
StringBuilder
reaches a length of the threshold divided by three, as before that, it is impossible to have aUTF-8
length greater than the threshold. However, that will be only beneficial if it happens that you don’t reachthreshold / 3
in some executions.