How to disable onItemSelectedListener to be invoke

Question

Just wondering how you handle the following problem: a result is calculated depending on two spinners' selected items. To handle the UI things, i.e. a user picks a new item in one of the spinners, I install a listener using setOnItemSelectedListener for the spinner in my onCreate() method of the activity.

Now: that works, of course, fine. The listener's work is to trigger a new calculation of the result.

The problem: because I intercept onPause() onResume() to save/restore the last state, I got a method that sets these two spinners' selected item programmatically like in here:

startSpinner.setSelection(pStart);
destSpinner.setSelection(pDest);

These two calls invoke the listeners, too! My calculation method for the result plus the notification of a new result set is invoked twice here!

A stupid direct approach for this would be to have a boolean variable disabling whatever the listener does inside, setting it before setting the selected items and resetting it afterwards. Okay. But is there a better method??

I don't want listeners to be called by code - actions, only by user actions! :-(

How do you do it? Thanks!

Answer 1

A cleaner solution, in my opinion, to differentiate between programmatic and user-initiated changes is the following:

Create your listener for the spinner as both an OnTouchListener and OnItemSelectedListener

public class SpinnerInteractionListener implements AdapterView.OnItemSelectedListener, View.OnTouchListener {

    boolean userSelect = false;

    @Override
    public boolean onTouch(View v, MotionEvent event) {
        userSelect = true;
        return false;
    }

    @Override
    public void onItemSelected(AdapterView<?> parent, View view, int pos, long id) {
        if (userSelect) { 
            // Your selection handling code here
            userSelect = false;
        }
    }

}

Add the listener to the spinner registering for both event types

SpinnerInteractionListener listener = new SpinnerInteractionListener();
mSpinnerView.setOnTouchListener(listener);
mSpinnerView.setOnItemSelectedListener(listener);

This way, any unexpected calls to your handler method due to initialization or re-initialization will be ignored.

Answer 2

Add the OnItemSelectedListener for each spinner after you have set any previous value in onResume.

Answer 3

I have an easier, and I think, better solution. Since I had to refresh the spinners even after initialization, this is a more generic approach. Please refer the accepted answer:

Undesired onItemSelected calls

Answer 4

Spinner.setSelection(int position, boolean animate) does trigger the listener on 4.3

Answer 5

It is very easy you can call the Spinner.setSelection(int position, boolean animate) method with false so the listeners will not react on the change.

Answer 6

When Spinner.setSelection(position) is used, it always activates setOnItemSelectedListener()

To avoid firing the code twice I use this solution:

private mIsSpinnerFirstCall=true;

...
Spinner.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener() {
    public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {
        //If a new value is selected (avoid activating on setSelection())
        if(!mIsSpinnerFirstCall) {
            // Your code goes gere
        }
        mIsSpinnerFirstCall = false;
    }

    public void onNothingSelected(AdapterView<?> arg0) {
    }
});

This solution is valid when you are sure that Spinner.setSelection(position) us used. Also, it is important to set mIsSpinnerFirstCall=true each time before using Spinner.setSelection(position)