Which Ruby memoize pattern does ActiveSupport::Mem

2019-03-08 07:15发布

So in Rails 3.2, ActiveSupport::Memoizable has been deprecated.

The message reads:

DEPRECATION WARNING: ActiveSupport::Memoizable is deprecated and
will be removed in future releases,simply use Ruby memoization
pattern instead.

It refers to "Ruby memoization pattern" (singular) as if there's one pattern we should all know and refer to...

I presume they mean something like:

def my_method
  @my_method ||= # ... go get the value
end

or

def my_method
  return @my_method if defined?(@my_method)

  @my_method = # ... go get the value
end

Is there something else I've missed?

4条回答
你好瞎i
2楼-- · 2019-03-08 07:29

Just an addition to the top answer, to memoize a class method use the following pattern:

class Foo
  class << self
    def bar
      @bar ||= begin
        # ...
      end
    end
  end
end
查看更多
【Aperson】
3楼-- · 2019-03-08 07:36

Here is the commit (and subsequent discussion) where Memoizable was deprecated: https://github.com/rails/rails/commit/36253916b0b788d6ded56669d37c96ed05c92c5c

The author advocates the @foo ||= ... approach and points to this commit as an example for migration: https://github.com/rails/rails/commit/f2c0fb32c0dce7f8da0ce446e2d2f0cba5fd44b3.

Edit: Note that I don't necessarily interpret this change as meaning that all instances of memoize can or should be replaced w/ this pattern. I read it as meaning that Memoizable is no longer needed/wanted in the Rails code itself. As the comments point out, Memoizable is much more than just a wrapper around @foo ||= .... If you need those features, go ahead and use Memoizable, you'll just have to get it from somewhere other than ActiveSupport (I'm guessing someone will fork a gem version, if they haven't already).

查看更多
手持菜刀,她持情操
4楼-- · 2019-03-08 07:36

Another option is to use the Memoist gem:

It is a direct extraction from ActiveSupport::Memoizable and can be used as a drop-in replacement. Just require 'memoist' and change

extend ActiveSupport::Memoizable

to

extend Memoist
查看更多
够拽才男人
5楼-- · 2019-03-08 07:48

Based upon the comments on the commit referenced above by avaynshtok, I’m going with this:

ActiveSupport::Deprecation.silence { extend ActiveSupport::Memoizable }

… because I figure I’ll know when Memoizable is ripped out of ActiveSupport from my RSpec suite dying right out of the starting gate.

查看更多
登录 后发表回答