Rspec: Testing nested destroy action

2019-03-03 03:38发布

I am trying to test the 'destroy' action for my nested comments controller. Post has_many Comments. I have ran into similar issues before and understand that I need to pass an id, but I'm still running into a very familiar error...

Failures:

  1) CommentsController#DELETE destroy deletes a comment
     Failure/Error: delete :destroy, comment: create(:comment), post_id: @post
     ActionController::UrlGenerationError:
       No route matches {:action=>"destroy", :comment=>"1", :controller=>"comments", :post_id=>"1"}
     # ./spec/controllers/comments_controller_spec.rb:19:in `block (3 levels) in <top (required)>'

comments_controller_spec.rb

RSpec.describe CommentsController, :type => :controller do
        before :each do
          @post = FactoryGirl.create(:post)
        end


    ....


        describe '#DELETE destroy' do
          it 'deletes a comment' do
            delete :destroy, comment: create(:comment), post_id: @post
            expect(response).to redirect_to post_path
          end
        end
end

comments_controller.rb

def destroy
    @post = Post.find(params[:post_id])
    @comment = @post.comments.find(params[:id])

    @comment.destroy
    redirect_to post_path(@post)
end

routes.rb

 resources :posts do
  resources :comments
end

rake routes

☹ rake routes
           Prefix Verb   URI Pattern                                 Controller#Action
             root GET    /                                           posts#index
    post_comments GET    /posts/:post_id/comments(.:format)          comments#index
                  POST   /posts/:post_id/comments(.:format)          comments#create
 new_post_comment GET    /posts/:post_id/comments/new(.:format)      comments#new
edit_post_comment GET    /posts/:post_id/comments/:id/edit(.:format) comments#edit
     post_comment GET    /posts/:post_id/comments/:id(.:format)      comments#show
                  PATCH  /posts/:post_id/comments/:id(.:format)      comments#update
                  PUT    /posts/:post_id/comments/:id(.:format)      comments#update
                  DELETE /posts/:post_id/comments/:id(.:format)      comments#destroy
            posts GET    /posts(.:format)                            posts#index
                  POST   /posts(.:format)                            posts#create
         new_post GET    /posts/new(.:format)                        posts#new
        edit_post GET    /posts/:id/edit(.:format)                   posts#edit
             post GET    /posts/:id(.:format)                        posts#show
                  PATCH  /posts/:id(.:format)                        posts#update
                  PUT    /posts/:id(.:format)                        posts#update
                  DELETE /posts/:id(.:format)                        posts#destroy

1条回答
淡お忘
2楼-- · 2019-03-03 04:03

The route that you want to request is this:

/posts/:post_id/comments/:id(.:format)

But you are sending the following parameters:

{:action=>"destroy", :comment=>"1", :controller=>"comments", :post_id=>"1"}

You need to send the comment.id as the id parameter.

Try this:

describe '#DELETE destroy' do
  it 'deletes a comment' do
    comment = create(:comment)
    @post.comments << comment
    # Also, test if the action really deletes a comment.
    expect{delete :destroy, id: comment.id, post_id: @post}.
    to change{@post.comments.count}.by(-1)
    expect(response).to redirect_to post_path
  end
end
查看更多
登录 后发表回答