Create message while sending Image through Asmack

There is an issue that I am facing while sending Images through XMPP.Below is the code snippet that i have done. I don't know what is wrong with the code .

Message msg = new Message(emailId, Message.Type.chat);
            ImageTransferExtension transfer = new ImageTransferExtension();
            transfer.setImageName(mImageUri.getEncodedPath());
            transfer.setUserRecipient(emailId);
            msg.addExtension(transfer);

And here is the ImagesTransferExtension code snippet

EDIT :

public class ImageTransferExtension implements PacketExtension {

private String userRecipient;
private String ftpUrl;
private String httpUrl;
private String id;
private String typeOfMessage;
private String fieldName;
private String duration;

@Override
public String getElementName() {
    // TODO Auto-generated method stub
    return "x";
}

@Override
public String getNamespace() {
    // TODO Auto-generated method stub
    return "jabber:client";
}

@Override
public String toXML() {
    StringBuilder builder = new StringBuilder();
    builder.append("<" + getElementName() + " xmlns=\"" + getNamespace()
            + "\">");
    if (ftpUrl != null) {
        builder.append("<ftpUrl>").append(ftpUrl).append("</ftpUrl>");
    }
    if (httpUrl != null) {
        builder.append("<httpUrl>").append(httpUrl).append("</httpUrl>");
    }
    if (typeOfMessage != null) {
        builder.append("<typeOfMessage>").append(typeOfMessage)
                .append("</typeOfMessage>");
    }
    if (fieldName != null) {
        builder.append("<fieldName>").append(fieldName)
                .append("</fieldName>");
    }
    if (duration != null) {
        builder.append("<duration>").append(duration).append("</duration>");
    }
    builder.append("</" + getElementName() + ">");

    return builder.toString();
}

public String getUserRecipient() {
    return userRecipient;
}

public void setUserRecipient(String userRecipient) {
    this.userRecipient = userRecipient;
}

public String getId() {
    return id;
}

public void setId(String id) {
    this.id = id;
}

}

I don't know what to pass in the Namespace and the Element. I went through the document but found no solution.

标签： android xmpp asmack

1条回答

Evening l夕情丶

2楼-- · 2019-03-02 06:32

You can use any name and namespace for your custom packets, but XML stream of your outgoing packets should be valid and well-formed XML document. In your example I see unbound ftpurl, httpurl, imageName nodes. Any good XML/XMPP parser will throw error, because your stream is not well-formed. Common practice is - wrap all you custom nodes in one top-level node and define namespace, like this:

<i xmlns="my:image:transfer">
 <httpurl>http://my.image.jpg</httpurl>
 <ftpurl>ftp://my/image.jpg</ftpurl>
</i>

This will cause XML parser to treat all your custom XML nodes as they come from "my:image:transfer" namespace and XML stream will be valid.

In the context of your "Image transfer extension" - you are trying to reinvent "Out-of-Band" XMPP File Transfer, which has well-known XMPP Extension - http://xmpp.org/extensions/xep-0066.html

Packets with OOB extension look like that:

<message from='stpeter@jabber.org/work'
         to='MaineBoy@jabber.org/home'>
  <body>Yeah, but do you have a license to Jabber?</body>
  <x xmlns='jabber:x:oob'>
    <url>http://www.jabber.org/images/psa-license.jpg</url>
    <desc>Jabber license</desc>
  </x>
</message>

Smack PacketExtension for this type of payload should look like:

public class OutOfBandData implements PacketExtension {

    String description;
    String url;

    @Override
    public String getElementName() {
        return "x";
    }

    @Override
    public String getNamespace() {
        return "jabber:x:oob";
    }

    @Override
    public String toXML() {
    StringBuilder builder = new StringBuilder();
    builder.("<" + getElementName() + " xmlns=\"" + getNamespace() + "\">");
    if (url != null) {
        builder.append("<url>").append(url).append("</url>");
    }
    if (description != null) {
        builder.append("<desc>").append(description).append("</desc>");
    }
    builder.append("</" + getElementName() + ">");
    return builder.toString();
    }

    public String getDescription() {
        return description;
    }

    public void setDescription(String description) {
        this.description = description;
    }

    public String getUrl() {
        return url;
    }

    public void setUrl(String imageUrl) {
        this.url = imageUrl;
    }

This is not far from your implementation, but chances where other XMPP clients understand your "Image Transfer" are growing.

0人赞添加讨论(0) 举报

Create message while sending Image through Asmack

采纳回答

编辑标签

举报内容

检举类型

检举原因

检举说明(必填)

打开微信“扫一扫”，打开网页后点击屏幕右上角分享按钮

付费偷看金额在0.1-10元之间