While looking through some old code I came across this gem:
MyObject o = new MyObject("parameter");
if (o == null) o = new MyObject("fallback parameter");
The second line is marked in Eclipse as dead code, and I understand why. No exception seems to be explicitly thrown, and it isn't possible for the MyObject
constructor to throw any kind of exception (such as NullPointerException
s).
My question is why there is a null check? Was it previously possible in an old version of Java for a constructor to return null? Or is this simply useless and dead code?
It's simply dead code.
new MyObject("parameter")
will not returnnull
in any version of java.This was simply usesless dead code. Once CTOR has executed successfully, you have reference to the object.
From section 15.9.4 of the JLS:
So no, it can never return null.
When you create a new Object(), you create an address in memory, and this address is not 'null', but your Object may be empty.
You have to test 'null' for Object transmitted by parameters.
My guess is that it was written by a C programmer who is used to testing the return value of
malloc()
forNULL
,malloc()
can returnNULL
if your system runs out of memory.The code doesn't make sense in Java since Java will throw an OutOfMemoryError` if it runs out of memory.
The code is dead in any version of java. It's not possible for a constructor to return
null
and even if an exception would be thrown from the constructor, the next line won't be called.