In my project there is a Form mainForm
in which there are two textBoxes txtUserName
and txtPassword
and also a button btnLogin
.
I have given the following txtUserName
properties:
txtUserName Properties
AutoCompleteCustomSource - Collection
--> Administrator
--> Clerk
AutoCompleteMode - Suggest
AutoCompleteSource - CustomSource
btnLogin_Click Event
if (txtUserName.Text.Equals("Administrator") && txtPassword.Text.Equals("123"))
{
//function to access admin features
}
else if (txtUserName.Text.Equals("Clerk") && txtPassword.Text.Equals("123"))
{
//function to access clerk features
}
else
{
MessageBox.Show("Please Enter correct details", "Login Error");
}
I have setted the mainForm
keypreview
to true
and implemented function to keyDown event of mainForm
which is shown in the below code:
mainForm_KeyDownEvent
if (e.KeyCode.Equals(Keys.Enter)) //Invokes whenever Enter is pressed
{
btnLogin_Click(sender,e); //login
}
Now my problem is that whenever the focus is on txtUserName
and pressing A
, dropdown is showing to select "Administrator" (which is defined in collections as I shown in above properties). When I click Enter
on keyboard it is showing MessageBox instead of selecting "Administrator". I know that is invoking the keydown event of mainForm
. How to disable the keyDown event, when it is on textbox dropdown thing so that I can press enter
?
EDIT:
I tried the below code in public form()
:(not working)
InitializeComponent();
if (txtUserName.AutoCompleteMode) { /* showing red scribbles */
this.KeyDown -= mainForm_KeyDown;
}
You need to override the keydown event handler.
You should not be handling the Enter key at all. You can remove your
KeyDown
handler, and instead use theAcceptButton
property of the form to set the button that gets "clicked" when Enter is pressed. This is already supposed to not "click" the button when another control has already handled the Enter key.That isn't enough for your situation, because standard Windows behaviour is for the Enter key to press the default button. Press Win+R, for example, to get the Run... dialog, start typing C:\Use, press Down to select C:\Users, press Enter, and see what happens.
In order to override that behaviour, you need to make the text box tell the form that it will be handling the Enter key itself, so that the form won't send it to the default button. This can be done by creating a derived class and overriding
IsInputKey
:However,
TextBox
implements autocompletion using theSHAutoComplete
function, which automatically creates anIAutoComplete
object behind the scenes. That object cannot be accessed, and because of that, theIsDroppedDown
property that I used inIsInputKey
cannot be created. It would be implemented usingIAutoCompleteDropDown.GetDropDownStatus
, but since the object is inaccessible, you cannot (reliably) determine whether the dropdown list is showing.You would need to either implement the auto completion without using the built-in
AutoComplete*
properties, or you would need to always suppress the Enter key (remove the&& IsDroppedDown
in the aboveIsInputKey
).Update: here's how to create an
IAutoComplete
object manually. The strings Administrator and Clerk are hardcoded. The GetDropDownStatus function is used to suppress any default button's handling of Enter when the drop down list is visible. Feedback welcome.IAutoComplete.cs:
IAutoComplete2.cs:
AutoCompleteOptions.cs:
IAutoCompleteDropDown.cs:
AutoCompleteDropDownFlags.cs:
IAutoCompleteClass.cs:
EnumString.cs:
MyTextBox.cs:
Actually, you have two issues.
First off, set the AutoCompleteMode property of txtUserName to "SuggestAppend" instead of simply "Suggest." This way, if the user types the first letter or two, the correct entry will automatically be appended to the txtUSerName.Text.
Next, modify your Form code as follows:
In the above, the Key Down event handling code tests to see if the password text box has the focus (meaning, the user has presumable entered a user name already, and a password, and is ready to submit the data). If so, the btnLogin_Click event is called. Otherwise, (meaning, txtUserName probably has the focus) control is passed to txtPassword to continue data entry.
UPDATE: re - Your comment:
Simply kill the logic in the Key Down Event handler like so:
Revised Event Handling Code:
Note, another minor improvement (considering the overall structure of your code) would be to use a combo box for selection of UserName, and set the autocomplete source to "ListItems" then enter your options the same as with the text box. This requires the user to select from the pre-defined list. This still has scaleability issues similar to the previous, but eliminates an unnecessary step for the user if they simply make a typo while entering User Name data.
Remember that users tend to dislike unnecessary interruption by pop-up messages. Allow them to select the appropriate "user name" from a drop down, type in the proper password, and move on.
There are some better ways to do all of this, but this should tune up what you have into working order.
On a final note, let me observe that eventually you will probably want to find a more robust way of performing this sort of validation. Any time you need to add users (which, in your code, appear to be defined more as "groups" you will need to add to your conditional event handling tree.
You might check into persisting usernames and passwords in an encrypted file or database, and load them into a dictionary or something at run time. Then perform a key/value lookup on user/Password.
Or something.
Anyway, hope that helps.
UPDATE 2: The complete code all in one shot. This should behave the way you are asking:
Try this. Hopefully it will not cause any problem on pressing enter while your focus is on txtUsername or else where
If you write
a
intxtUserName
and press enter, YourAdmministrator
choice will be selected from yourautocompletecustomsource
usingregular expression
and focus will go totxtPassword
. My regular expression is very flexible you can made it bit restricted as following to match strictly from beginning and also can remove ignore caseRegex rg = new Regex("^" + txtUserName.Text);