I use the JAXBContext.newInstance operation in my JBoss based web application. This operation, as I understand, is very heavyweight. I only require two unique instances of the Marshaller class.
My initial proposal is to have a static initializer block that will initialize these two instances only once upon the class loading:
public class MyWebApp {
private static Marshaller requestMarshaller;
private static Marshaller responseMarshaller;
static {
try {
// one time instance creation
requestMarshaller = JAXBContext.newInstance(Request.class).createMarshaller();
responseMarshaller = JAXBContext.newInstance(Response.class).createMarshaller();
} catch (JAXBException e) {
e.printStackTrace();
}
}
private void doSomething() {
requestMarshaller.marshall(...);
responseMarshaller.marshall(...);
...
}
}
If this is a reasonable solution then I guess I'll have answered my own question, but I would like to know if this is the correct way to do this?
JAXBContext should always be static, it is thread safe.
Marshallers and Unmarshallers are cheap and not thread safe. You should create once JAXBContext and create marshallers/unmarshallers for every operation
Use same marshaller to marshall everything (add all classes when you create the context).
I recently did some performance testing with JAXBContext.newInstance and the result is documented here .
http://app-inf.blogspot.com/2012/10/performance-tuning-logging-right-way.html
When called by one thread, using a fairly large schema with ~195 classes generated, it took ~400ms to finish. When called by 20 threads simultaneously, it caused cpu contentions, and took up to ~5000ms to finish. The creation of marshaller and object serialization of a small object only too ~14ms.
A JAXB implementation (Metro, EclipseLink MOXy, Apache JaxMe, etc) typically initializes its metadata during the
JAXBContext.newInstance
call. All OXM tools need to initialize mapping metadata at some point and try to minimize the cost of this operation. Since it is impossible to do it with zero cost, it is best to only do it once. Instances of JAXBContext are thread safe, so yes you only need to create it once.From the JAXB 2.2 Specification, Section 4.2 JAXB Context:
Instances of Marshaller and Unmarshaller are not thread safe and must not be shared among threads, they are lightweight to create.
You should create single
JAXBContext
object per bean class. see thisOne can use javax.xml.bind.JAXB. It has direct Marshal and unmarshal methods. So you don't have to worry about instance creation of JAXB.
e.g. JAXB.unmarshal(inputStream/inputFile, outputClassExpected) or JAXB.marshal(jaxbObject, xmlOutputFile/xmlOutputStream)