What are the potential issues using this static cl

Question

Here is my sample code:

public static class MySqlHelper
{
    private static string constring = ConfigurationManager.ConnectionStrings["MyConnString"].ConnectionString;

    public static int ExecuteNonQuery(string mysqlquery)
    {
        SqlConnection conn = new SqlConnection(connString);
        SqlCommand cmd = new SqlCommand(mysqlquery, conn);
        int result;

        try
        {
            conn.Open();
            result= cmd.ExecuteNonQuery();
        }
        finally
        {
            conn.Close();
        }
        return result;
    }
}

Usage: MySqlHelper.ExecuteNonQuery("select * from customers");

I would like to know the issues using this static class.

I can change my class as mentioned here but I have been using this class in couple of websites and I will need couple days to change it in every place and test it out.

Thanks for any inputs.

Edit: Updated the code. Does that make difference on the answers provided? Sorry, I should have posted in the beginning.

Answer 1

As such no issue it depends how you are using this class, ideally it part of abstract factory pattern to have static connections so that same connection can be used all over application, but having methods such as executereader and other mthods is not a good choice. similarly always check that connection has not been closed or its state before its usage, because if you are having static connection and you used using syntax with executereader then it will close the connection and if some other method used connection after this then it will get the error