What is the most efficient way to count number of

Question

I am a bit new to Objective C and was wondering if there is a better way to count words in a string.

ie:

NSString *str = @"this is a string";

// return should be 4 words ..

The way I now how to do it is by breaking the string into an array of words space (' ') character and count the array.

Any advise will be appreciated! Thanks!! :)

EDIT: For those of you who came here looking for answer; I found a similar post with an excellent reply.

How to count words within a text string?

Answer 1

There are two ways that don't involve collecting an array of words, and should be smarter than just breaking on spaces:

• NSString's enumerateSubstringsInRange:options:usingBlock: method. Introduced to Cocoa Touch in iOS 4.0.
• CFStringTokenizer.

I would use one of these, even if I did want to collect or otherwise use the words.

Answer 2

Are you sure you have a bottleneck in that part of code? If not (which is quite probable), then splitting on spaces seems perfectly acceptable to me. You could create a C string and count the spaces instead, but a lot of times such an “optimized” version is actually slower than the original one. That is, assuming that your current code looks like this:

NSUInteger wordCount = [[someString componentsSeparatedByString:@" "] count];

This is not exactly correct (see @"___" where underscore is a space), but maybe you really use a regex and split on \s+?

Answer 3

In this situation, I'd use an NSScanner like so:

NSString *str = @"this is a string";
NSScanner *scanner = [NSScanner scannerWithString:str];
NSCharacterSet *whiteSpace = [NSCharacterSet whitespaceAndNewlineCharacterSet];
NSCharacterSet *nonWhitespace = [whiteSpace invertedSet];
int wordcount = 0;

while(![scanner isAtEnd])
{
    [scanner scanUpToCharactersFromSet:nonWhitespace intoString:nil];
    [scanner scanUpToCharactersFromSet:whitespace intoString:nil];
    wordcount++;
}

This only creates two additional objects, no matter how long the string is.

Answer 4

This code will count the number of words (i.e., non-empty substrings) contained in a string that are separated by any number of space or line break characters:

NSUInteger wordCount = 0;

for (NSString* word in [someString
    componentsSeparatedByCharactersInSet:
    [NSMutableCharacterSet characterSetWithCharactersInString:@" \n"]]) {

    if (![word  isEqual: @""]) {
        wordCount++;
    }

}

It's a slight improvement to zoul's answer without recurring to regexes.

Answer 5

Unless you're going to be doing it hundreds of times a second, I would just opt for the readable solution, something like the following pseudocode:

def count (str):
    lastchar = " "
    count = 0
    for char as every character in string:
        if char is not whitespace and lastchar is whitespace:
            count = count + 1
        lastchar = char
    return count

It seems a bit of a waste to create a whole array of other strings just so you can count them and throw them away.

And if, for some reason, it becomes an issue, you can just replace the function body with a faster version. Make sure it is a problem first however. Optimisation of code that's fast enough already is wasted effort.

Answer 6

One liner accurate solution:

return [[self componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]] filteredArrayUsingPredicate:[NSPredicate predicateWithFormat:@"length > 0"]].count;