We're trying to run SQL files containing multiple insert statements as a single query, but it seems rollback
fails when any of the statements contain an error.
MySQLd configuration:
sql_mode = STRICT_ALL_TABLES
default-storage-engine = innodb
Python code:
from contextlib import closing
import MySQLdb
database_connection = MySQLdb.connect(host="127.0.0.1", user="root")
with closing(database_connection.cursor()) as cursor:
database_connection.begin()
cursor.execute('DROP DATABASE IF EXISTS db_name')
cursor.execute('CREATE DATABASE db_name')
cursor.execute('USE db_name')
cursor.execute('CREATE TABLE table_name(first_field INTEGER)')
with closing(database_connection.cursor()) as cursor:
try:
database_connection.begin()
cursor.execute('USE db_name')
cursor.execute('INSERT INTO table_name VALUES (1)')
cursor.execute('INSERT INTO table_name VALUES ("non-integer value")')
database_connection.commit()
except Exception as error:
print("Exception thrown: {0}".format(error))
database_connection.rollback()
print("Rolled back")
with closing(database_connection.cursor()) as cursor:
try:
database_connection.begin()
cursor.execute('USE db_name')
cursor.execute('INSERT INTO table_name VALUES (1); INSERT INTO table_name VALUES ("non-integer value")')
database_connection.commit()
except:
print("Exception thrown: {0}".format(error))
database_connection.rollback()
print("Rolled back")
Expected result: "Exception thrown" and "Rolled back" printed twice.
Actual result with MySQL-python 1.2.4:
Exception thrown: (1366, "Incorrect integer value: 'non-integer value' for column 'first_field' at row 1")
Rolled back
Exception thrown: (1366, "Incorrect integer value: 'non-integer value' for column 'first_field' at row 1")
Traceback (most recent call last):
File "test.py", line 30, in <module>
print("Rolled back")
File ".../python-2.7/lib/python2.7/contextlib.py", line 154, in __exit__
self.thing.close()
File ".../virtualenv-python-2.7/lib/python2.7/site-packages/MySQLdb/cursors.py", line 100, in close
while self.nextset(): pass
File ".../virtualenv-python-2.7/lib/python2.7/site-packages/MySQLdb/cursors.py", line 132, in nextset
nr = db.next_result()
_mysql_exceptions.OperationalError: (1366, "Incorrect integer value: 'non-integer value' for column 'first_field' at row 1")
What gives? Do we really have to parse the SQL to split up statements (with all the escape and quote handling that entails) to run them in multiple execute
s?
I think you need to pass
multi=True
toexecute
when using multiple statements, see http://dev.mysql.com/doc/connector-python/en/connector-python-api-mysqlcursor-execute.htmlUpdate: This applies to the
mysql.connector
module, notMySQLdb
used in this case.use below line item to execute statement :
for _ in cursor.execute(query, multi=True): pass
Tried the
multi=True
method, but ended up splitting the file by semi and looping through. Obviously not going to work if you have escaped semis, but seemed like the best method for me.Apparently there is no way to do this in
MySQLdb
(aka.MySQL-python
), so we ended up justcommunicate
ing the data tosubprocess.Popen([mysql, ...], stdin=subprocess.PIPE)
and checking thereturncode
.Using the
mysql
program via Popen will definitely work, but if you want to just use an existing connection (and cursor), thesqlparse
package has asplit
function that will split into statements. I'm not sure what the compatiblity is like, but I have a script that does:It's only ever fed DROP TABLE and CREATE TABLE statements, but works for me.
https://pypi.python.org/pypi/sqlparse
Like all Python DB-API 2.0 implementations, the
cursor.execute()
method is designed take only one statement, because it makes guarantees about the state of the cursor afterward.Use the
cursor.executemany()
method instead. Do note that, as per the DB-API 2.0 specification:Using this for multiple
INSERT
statements should be just fine:If you need to execute a series of disparate statements like from a script, then for most cases you can just split the statements on
;
and feed each statement tocursor.execute()
separately.