C : stack memory, goto and “jump into scope of ide

Question

I found that this refuses to compile :

int test_alloc_stack(int size){
    if(0) goto error; // same issue whatever conditional is used
    int apply[size];
    give_values(apply,size);
    return 1;
    error:
        return 0;
}

The error I get is : "jump into scope of identifier with variably modified type". Eliminating the line with "goto" and the jump to error solves the issues.

If I use dynamic allocation for apply, then the problem also disappear. This compiles fine:

 int test_alloc_heap(int size){
    if(0) goto error;
    int * apply = calloc(sizeof(int),size);
    give_values(apply,size);
    free(apply);
    return 1;
    error : return 0;
}

What is going on ?

Answer 1

The declaration:

int apply[size];

creates a variable length array. When it goes out of scope, the compiler must produce some code that cleans up the allocation for that array. Jumping into the scope of such an object is forbidden I imagine because some implementations might need to arrange for some initialization that the clean up code would require, and if you jump into the scope the initialization would be bypassed.

If you change to a dynamic allocation, the initialization and clean up become your responsibility instead of the compiler's.

Answer 2

It is forbidden by the standard:

C99 standard, paragraph 6.8.6.1

Constraints

[...] A goto statement shall not jump from outside the scope of an identifier having a variably modified type to inside the scope of that identifier.

Which is exactly what your goto is doing, namely, jumping from outside the scope of apply to inside it.

You can use the following workaround to limit the scope of apply:

if(0) goto error;

{
    int apply[size];
    give_values(apply,size);
    return 1;
}

error:
return 0;

Answer 3

Your goto makes you skip the line that allocates apply (at runtime).

You can solve the problem in one of four ways:

1: Rewrite your code so you don't use goto.

2: Move the declaration of apply to before the goto.

3: Change the scope so that error: is outside the scope of apply:

int test_alloc_stack(int size){
    if(0) goto error; // same issue whatever conditional is used
    {
        int apply[size];
        give_values(apply,size);
        return 1;
    }
    error:
        return 0;
}

4: Change the variable declaration so its size can be determined at compile-time.