SQL Insert executes twice, php

2020-02-16 04:07发布

Couldn't find a straight answer to this. My custom wordpress php code seems to be executed twice when I click on the submit once. When clicked, the codes adds two cities with the same name. As you can see, I tried to aviod this by checking for duplicates, but it ignores it... I tried moving the html to a function, but not help there either. Now my code looks weird and still no solution. Any new ideas?

<?php get_header(); ?>

<div id="primary" class="content-area">
    <main id="main" class="site-main" role="main">
        <?php
        // Start the loop.
        while ( have_posts() ) : the_post();

            // Include the page content template.
            get_template_part( 'template-parts/content', 'page' );

            if ( comments_open() || get_comments_number() ) {
                comments_template();
            }

            // End of the loop.
        endwhile;
        ?>

    </main><!-- .site-main -->

<?php

function showForm() {

    echo "<form name='submit' method='post'>";
    echo "<select name='countriesSelect'>
            <option value='-1'>Choose...</option>";
    $conn = new mysqli('localhost','a','b','c');
    $query = "SELECT id,country_name FROM countries";
    $result = $conn->query($query);

    while($row = $result->fetch_assoc()) {
        echo "<option value='" . $row['id'] . "'>" . $row['country_name'] . "</option>";
    }
    $conn->close();
    echo "</select><br /><br /> 

        Now choose a new city:&nbsp;&nbsp;<input type='text' name='cityname' maxlength='30' size='30' value='' style='width: 300px;' /><br /><br />

        That is it: <br />
        <input type='submit' value='Add new city' /><br /><br />
    </form>";
    return;
}

if (!empty($_POST['cityname']) && !empty($_POST['countriesSelect'])) {

    $cityname = $_POST['cityname'];
    $countriesSelect = $_POST['countriesSelect'];

    // make sure city doesn't exist - also because for some unknown reason this script is called twice =/
    $db = new mysqli('localhost','a','b','c');
    $query = "SELECT city_name FROM cities WHERE city_name='$cityname'";
    $result = $db->query($query);
    $row = $result->fetch_assoc();
    if (empty($row['city_name'])) {

        // add new city
        $query = "INSERT INTO cities (country_id, city_name, amount_raised_usd) VALUES ($countriesSelect, '$cityname', 0)";
        $result = $db->query($query);

        if ($db->query($query) === TRUE) {
            echo "<div style='color: green;'>New city added successfully. Add another?";
        } else {
            echo "<div style='color: red;'>Error: " . $query . " :: " . $db->error; 
        }

        echo '</div><br /><br />';
    }

    $db->close();
    showForm();

} else {
    showForm();
}
?>

    <?php get_sidebar( 'content-bottom' ); ?>

</div><!-- .content-area -->

<?php get_footer(); ?>

2条回答
趁早两清
2楼-- · 2020-02-16 04:18

Do you see this

$result = $db->query($query);

And the next line:

if ($db->query($query) === TRUE) {

This means that you run your query twice. Remove one of the $db->query, e.g.:

$result = $db->query($query);
if ($result === TRUE) {    /* do stuff */
查看更多
迷人小祖宗
3楼-- · 2020-02-16 04:42

you execute the query twice:

$result = $db->query($query);
if ($db->query($query) === TRUE) {

should be:

$result = $db->query($query);
if ($result === TRUE) {
查看更多
登录 后发表回答