UsingjQuery.sap.includeScript().then() in HCP Firo

Question

I'm trying to include googlemaps in sapui5

jQuery.sap.includeScript({
                url: "https://maps.googleapis.com/maps/api/js?key=XXXX",
                promisify: true
            }).then(function() { ... } )

This Promise works fine when I run in hanatrial webide, But when I deploy it to hana cloud platform it is not working. The error message it gives me is :

InterceptService.js:1 Uncaught (in promise) TypeError: u.indexOf is not a function(…) sap.ushell.cloudServices.interceptor.InterceptService._invokeFilters @ InterceptService.js:1

jQuery.sap.includeScript @ InterceptService.js:1

onAfterRendering @ Worklist.controller.js:37

So I open InterceptService.js , The code fragment in the library that produced this error is

{if(u.indexOf('/sap/fiori/../../')>0){u=u.replace('/sap/fiori/../../','/');}

I do use HCP Portal Service to produce HCP Fiori Launchpad Platform. How to fix this? What I did wrong?

Thanks a lot!

Answer 1

It is indeed issue of InterceptorService, which does not support the syntax of includeScript with object as first argument.

I've forwarded a code of the solution to implementation team of HCP Portal Service and it will be fixed in the next release.

So far, you can achieve the same functionality with the following workaround:

new Promise(function(fnResolve, fnReject) {
    jQuery.sap.includeScript(
        "https://maps.googleapis.com/maps/api/js?key=XXXX", 
        "mapsScriptId", fnResolve, fnReject
    );
}).then(function() { ... } )

See how UI5 implements it: https://github.com/SAP/openui5/blob/rel-1.38/src/sap.ui.core/src/jquery.sap.global.js#L4387-L4389

Answer 2

Looks like the InterceptService doesn't support the newest signature of jQuery.sap.includeScript (where parameters are provided in a configuration object instead of as individual arguments) yet.

Midterm, the InterceptService needs to be enhanced / fixed. Short-term, you might fall back to the old signature jQuery.sap.includeScript(url, id, onload, onerror). There is unfortunately no way to get a Promise with the old signature.