I need to get the value of the checked checkbox (only one is allowed to be checked at a time), and I have this verbose code to do so:
if (!checkboxSelected) {
return;
}
if($("#ckbx_produceusage").is(':checked')) {
rptval = $('#ckbx_produceusage').val();
}
else if($("#ckbx_deliveryperformance").is(':checked')) {
rptval = $('#ckbx_deliveryperformance').val();
}
else if($("#ckbx_fillrate").is(':checked')) {
rptval = $('#ckbx_fillrate').val();
}
else if($("#ckbx_pricecompliance").is(':checked')) {
rptval = $('#ckbx_pricecompliance').val();
}
setEmailAndGenerateValsForUnitReportPair(unitval, rptval);
Is there a way I can make this code less verbose without making it ungrokkable? I thought of dynamically adding a class to the checkbox that is checked, and then removing it from any that previously had that class added, and then getting the rptval based on which one is currently decorated with that class. That seems a bit smelly or Rubegoldbergesque, though, so am looking for a better solution.
UPDATE
For T.J. Crowder, here is the HTML (Razor/ASP.NET MVC style):
@foreach (var rpt in reports)
{
@* convert id to lowercase and no spaces *@
var morphedRptName = @rpt.report.Replace(" ", string.Empty).ToLower();
<input class="ckbx leftmargin8" id="ckbx_@(morphedRptName)" type="checkbox" value="@rpt.report" />@rpt.report
}
You also need to account for the situation where none are checked. Never assume something is set.
Try using .each()
Without changing your HTML, you can at least avoid repeating yourself by using a loop:
You could probably change your HTML such that the initial array could be a query rather than a hardcoded list of ID selectors.
JQuery collections are filterable, so I'd suggest using the following:
Note: The
.first()
may even be unnecessary since.val()
gets the value of the first element in the collection. Left in for legibility's sake.