Java Set gets full

2019-09-19 19:14发布

I am making a particle emitter. Every "Rendered" object is stored in a HashSet, and when there's lots of particles on the screen, the console spits out concurrent modification exceptions. I usually have a short lifetime on these particles so they get deleted after several seconds, but I am sure this could potentially be a problem in the future. How can I fix this?

EDIT: Code:

public class UpdatedManager {
private static Set<Updated> updates = new HashSet<>();

private UpdatedManager() {}

public static Set<Updated> getUpdates() {
    return new HashSet<Updated>(updates);
}
public static boolean registerUpdated(Updated u) {
    return updates.add(u);
}
public static boolean unregisterUpdated(Updated u) {
    return updates.remove(u);
}
public static void update() {
    for (Updated up : new HashSet<Updated>(updates))
        up.update();
}
public static Set<GameObject> getGameObjects() {
    Set<GameObject> objs = new HashSet<>();
    for (Updated up : new HashSet<Updated>(updates)) {
        if (up instanceof GameObject)
            objs.add((GameObject) up);
    }
    return objs;
}
public static Set<GameObject> getGameObjectsByName(String name) {
    Set<GameObject> objs = new HashSet<>();
    for (GameObject go : new HashSet<GameObject>(getGameObjects())) {
        if (go.getName() != null && go.getName().equals(name))
            objs.add(go);
    }
    return objs;
}
public static Set<Particle> getParticles() {
    Set<Particle> parts = new HashSet<>();
    for (Updated up : new HashSet<Updated>(updates)) {
        if (up instanceof Particle)
            parts.add((Particle) up);
    }
    return parts;
}
}

2条回答
你好瞎i
2楼-- · 2019-09-19 19:20

A ConcurrentModificationException means you modified the set while iterating over it. It does not mean the set is full.

For example, the following code will throw a ConcurrentModificationException:

Set<String> set = new HashSet<>();

set.add("Hello");

for(String s : set)
    set.add(s+" world");

Note that you are not guaranteed to get a ConcurrentModificationException, so you should avoid catching it. You should instead fix your code so that it doesn't cause the problem.

查看更多
时光不老,我们不散
3楼-- · 2019-09-19 19:34

What makes you think that the set is full?

Concurrent modification exceptions mean that the set is being accessed by different threads in an unsafe manner.

Try a synchronised set using the Collections utilities

HashSet hashSet = new HashSet();
Set set = Collections.synchronizedSet(hashSet);

or use the synchronized keyword for the method accessing the set.

查看更多
登录 后发表回答