PHP IRC Bot creating infinite loop

2019-09-05 22:21发布

站内问答 / PHP
713 2 5

Hello fellow developers of Stack Overflow! I recently got back into web development (although I wasn't too good at it before) with PHP being my weapon of choice. PHP seems to have changed since I was out of it, and combine that with the fact that I have never used PHP sockets, before lead to a disastrous first attempt to create an IRC bot (I am on an IRC channel where bot developing is big, and I want to integrate it into my website. Writing it in php also seems like a fun challenge). It created an infinite loop that made my browser go slow, and I wasn't able to copy any errors or warnings. Would the good folks of so mind looking over this script (based on this bot):

<!DOCTYPE html>
<html lang="en-US">
    <head>
        <title>Lucky Cloud</title>
    </head>

    <body>
        <?php
            error_reporting(E_ERROR);

            $bot = array(
                            "Host"     => "irc.quakenet.org",
                            "Channels" => ["#cplusplus", "#BotDevGroundZero"],
                            "Nick"     => "LuckyCloud",
                            "Ident"    => "LuckyCloud",
                            "Real"     => "LuckyCloud",
                            "Port"     => 6667
                   );
            $buffer = "";
        ?>

        <p>
            Server: <?php echo $bot["Host"]; ?><br />
            Channel(s): <?php foreach($bot["Channels"] as $channel) echo $channel.($channel != end($bot["Channels"]) ? ", " : ""); ?><br />
            Port: <? echo $bot["Port"]; ?><br />
            ___________________________________________________________________________________________________________________<br />
        </p>

        <?php
            global $socket;
            $socket = fsockopen($bot["host"], $bot["Port"]);

            function sendData($cmd, $msg = null) {
                if($msg == null) {
                    fputs($socket, $cmd."\r\n");
                    echo "<strong>".$cmd."</strong><br />";
                }

                else {
                    fputs($socket, $cmd." ".$msg."\r\n");
                    echo "<strong>".$cmd." ".$msg."</strong><br />";
                }
            }

            sendData("NICK", $bot["Nick"]);
            sendData("USER", $bot["Ident"]." ".$bot["Host"]." ".$bot["Real"]);

            $buffer = "";

            while(true) {
                foreach($bot["Channels"] as $channel) {
                    sendData("JOIN", $channel);
                }

                $buffer += fgets($socket, 1024);
                $temp = explode("\n", $buffer);
                $buffer = end($temp);

                foreach($temp as $line) {
                    echo $line;
                    $line = rtrim($line);
                    $line = explode($line);

                    if($line[0] == "PING") {
                        sendData("PONG", $line[1]);
                    }
                }
            }
        ?>
    </body>
</html>

sorry for any formatting issues. the cpanel editor was acting weird

标签： php irc
举报
2条回答
成全新的幸福
2楼-- · 2019-09-05 22:54

PHP is not the best thing for this job. It's really not good at keeping long running connections. This script might be used for short time joins, where you simply drop a message and leave. Something like "event based notification".

Several additions to your script:

  • timezone
  • error_reporting and display
  • timelimit 0
  • while modified to while (!feof($socket)) {
  • PING/PONG: replaced explode by substr
  • this connects to freenode, quakenet is a bitch - some more magic needed here :)
  • JOIN is inside the WHILE, but we need it only one time - guard added
  • be inside the channel to watch it connect
  • the output is not flushed... hmm..
<html lang="en-US">
<head>
    <title>Lucky Cloud</title>
</head>  
<body>
    <?php
        date_default_timezone_set('America/Los_Angeles');
        error_reporting(E_ALL);
        ini_set("display_errors", 1);
        set_time_limit(0);

        $bot = array(
            "Host"     => "kornbluth.freenode.net", #"underworld2.no.quakenet.org", #irc.quakenet.org",
            "Channels" => ["#testerchan"],
            "Nick"     => "Tester7888",
            "Ident"    => "Tester7888",
            "Real"     => "Susi Q",
            "Port"     => 6667
        );
    ?>

    <p>
        Server: <?php echo $bot["Host"]; ?><br />
        Channel(s): <?php foreach($bot["Channels"] as $key => $channel) { echo $channel; } ?><br />
        Port: <?php echo $bot["Port"]; ?><br />
        ___________________________________________________________________________________________________________________<br />
    </p>

    <?php
        global $socket;

        function sendData($cmd, $msg = null) {
            global $socket;
            if($msg == null) {
                fputs($socket, $cmd."\r\n");
                echo "<strong>".$cmd."</strong><br />";
            } else {
                fputs($socket, $cmd." ".$msg."\r\n");
                echo "<strong>".$cmd." ".$msg."</strong><br />";
            }
        }

        $socket = fsockopen($bot["Host"], $bot["Port"], $error1, $error2);
        if(!$socket) {
            echo 'Crap! fsockopen failed. Details: ' . $error1 . ': ' . $error2;
        }

        sendData("NICK", $bot["Nick"]);
        sendData("USER", $bot["Ident"]." ".$bot["Host"]." ".$bot["Real"]);

        $join_at_start = true;

        $buffer = "";

        while (!feof($socket)) {
            $buffer = trim(fgets($socket, 128));
            echo date('H:i')." ".nl2br($buffer)."<br/>";
            flush();

            # Ping <-> Pong
            if(substr($buffer, 0, 6) == "PING :") {
                fputs($socket, "PONG :".substr($buffer, 6)."\r\n");
                echo $buffer;
                flush();
            }

            // break out of while, 0 bytes
           /* $stream_meta_data = stream_get_meta_data($socket);
            if($stream_meta_data['unread_bytes'] <= 0) {
                break;
            }*/

            # join only one time
            if($join_at_start === true && false === strpos($buffer, 'Your host is trying to (re)connect too fast -- throttled')) {
                foreach($bot["Channels"] as $key => $channel) {
                   sendData("JOIN", $channel);
                   $join_at_start = false;
                }
            }
        }
    ?>
</body>

查看更多
0人赞 添加讨论(0) 举报
再贱就再见
3楼-- · 2019-09-05 23:03

You wont be able to implement it this way, what's causing the issue is simply that once the while(true) loop starts it wont stop.

You will need to separate the request from the processing loop. So put the loop as a background process (daemon) and then push your PINGS and PONGS ect to it via another interface like for example a threads database, then on each iteration of the loop, query the database for your PINGS and PONGS.

查看更多
0人赞 添加讨论(0) 举报
登录 后发表回答
相关问题
查看全部
相关文章
查看全部
收藏的人(5)