How to Dispose DbContext(or object) in asp.net mvc

问题:

For this Demo I have created a fake Database+repository as below

Fake Db + Repository

 public interface IDemoRepository
    {
        string[] GetUsers();
    }

    public class DemoRepository : IDemoRepository, IDisposable
    {

        public string[] GetUsers()
        {
            string[] Users = { "Robert","Linda","Jack"};
            return Users;
        }

        public void Dispose()
        {
            //do nothing     
            throw new Exception("Disposed is called");       
        }
    }

My Controller looks this

 public class TestController:Controller
    {
        protected IDemoRepository _repository;

        public BaseController(IDemoRepository repository)
        {
            _repository = repository;
        }

        public ActionResult()
       {  
             var users = _repository.GetUsers();
             Return View(users);
       }
    }

Ninject Part

I installed ninject from NUGet and added below code for resolving repositories

kernel.Bind<IDemoRepository>().To<DemoRepository>()

Ninject is not calling DemoRepository.Dispose, i added a break point even my current code is throwing error but Ninject is not calling DemoRepository.Dispose.

Can any body suggest me how dispose the object.

回答1:

Make sure that your repository is bound to the request scope in Ninject if you want it to be disposed:

kernel.Bind<IDemoRepository>().To<DemoRepository>().InRequestScope();

回答2:

You don't need to Dispose() of you DbContext, since it already manages all connections properly itself. Here's a quote from ASP.NET MVC Tip #34 – Dispose of Your DataContext (or Don’t):

The most important consequence of calling the DataContext.Dispose() method is that any open connections associated with the DataContext get closed. This might seem really important, but it’s not. The reason that it is not important is that the DataContext class already manages its connections. By default, the DataContext class opens and closes a connection automatically.

...

Most often, when you call the Dispose() method on the DataContext object, any database connection associated with the DataContext object is already closed. The DataContext object has closed the database connection right after executing the database query. So, the Dispose() method really doesn't have anything to do.