I am catching all throwables in a unit test wrapper method in order to reset some data in an external system. I want to re-throw the original exception when this is done and I am using this piece of code to do it:
if (t instanceof RuntimeException) {
throw (RuntimeException) t;
} else if (t instanceof Error) {
throw (Error) t;
} else {
throw new RuntimeException(t);
}
However, is there any existing utility call that does this already?
(I am catching throwables because AssertionErrors are Errors.)
Edit: To be honest, I don't really want to wrap the exception, so any trick that would allow me to throw any throwable (including checked exceptions) without declaring throws is acceptable.
Yes, there is a way to write a method that will avoid wrapping your checked exceptions. For this use case it is a perfect match, although you should definitely be very careful with it, since it can easily confuse the uninitiated. Here it is:
@SuppressWarnings("unchecked")
public static <T extends Throwable> void sneakyThrow(Throwable t) throws T {
throw (T) t;
}
and you'd use it as
catch (Throwable t) { sneakyThrow(t); }
As commented by Joachim Sauer, in certain cases it helps convince the compiler that the line calling sneakyThrow
causes the method to terminate. We can just change the declared return type:
@SuppressWarnings("unchecked")
public static <T extends Throwable> void sneakyThrow(Throwable t) throws T {
throw (T) t;
}
and use it like this:
catch (Throwable t) { throw sneakyThrow(t); }
For educational purposes it is nice to see what's going on at the bytecode level. The relevant snippet from javap -verbose UncheckedThrower
:
public static <T extends java.lang.Throwable> java.lang.RuntimeException sneakyThrow(java.lang.Throwable) throws T;
descriptor: (Ljava/lang/Throwable;)Ljava/lang/RuntimeException;
flags: ACC_PUBLIC, ACC_STATIC
Code:
stack=1, locals=1, args_size=1
0: aload_0
1: athrow
Exceptions:
throws java.lang.Throwable
Signature: #13 // <T:Ljava/lang/Throwable;>(Ljava/lang/Throwable;)Ljava/lang/RuntimeException;^TT;
Note there is no checkcast
instruction. The method even legitimately declares to throw any Throwable
, which is the erasure of T
.
The great Guava library has a Method Throwables.propagate(Throwable)
that does exactly what your code is doing: JavaDoc
From the doc:
Propagates throwable as-is if it is an instance of RuntimeException or Error, or else as a last resort, wraps it in a RuntimeException then propagates.
Perhaps setDefaultUncaughtExceptionHandler(Thread.UncaughtExceptionHandler)
can help you. There you can define a global exception handler for all exceptions that occur.