Is providing a Promise as a module's export a

2019-02-05 16:33发布

问题:

I need to write some modules that load data one time and then provide an interface to that data. I'd like to load the data asynchronously. My application already uses promises. Is providing a promise as the result of requiring a module a valid pattern/idiom?

Example Module:

var DB = require('promise-based-db-module');

module.exports =
  DB.fetch('foo')
  .then(function(foo){
    return {
        getId: function(){return foo.id;},
        getName: function(){return foo.name;}
    };
  });

Example Usage:

require('./myPromiseModule')
.then(function(dataInterface){
  // Use the data
});

UPDATE:

I've used this for a while now and it works great. One thing I've learned, and it's hinted at in the accepted answer, is that it is good to cache the promise itself, and whenever you want to access the data use then. The first time the data is accessed, the code will wait until the promise is resolved. Subsequent usage of then will return the data immediately. e.g.

var cachedPromise = require('./myPromiseModule');
cachedPromise.then(function(dataInterface){
  // Use the data
});
...
cachedPromise.then(function(dataInterface){
  // Use the data again somewhere else.
});

回答1:

This seems like a perfectly good interface for a module who's job is to do a one-time fetch of some data.

The data is obtained async so a promise makes sense for that. The goal is to fetch the data just once and then let all places this module gets used just have access to that original data. A promise works great for that too because it's a one-shot device that remembers its state.

Personally, I'm not sure why you need the getId() and getName() methods when you could just offer direct access to the properties, but either can work.

A downside to this interface is that there is no means of requesting a fresh copy of the data (newly loaded from the DB).