I want to extract .rar files using cmd shell so I wrote this code:
string commandLine = @"c:\progra~1\winrar\winrar e c:\download\TestedU.rar c:\download";
ProcessStartInfo PSI = new ProcessStartInfo("cmd.exe");
PSI.RedirectStandardInput = true;
PSI.RedirectStandardOutput = true;
PSI.RedirectStandardError = true;
PSI.UseShellExecute = false;
Process p = Process.Start(PSI);
StreamWriter SW = p.StandardInput;
StreamReader SR = p.StandardOutput;
SW.WriteLine(commandLine);
SW.Close();
The first time it worked fine, the second time it displayed nothing.
Use SevenZipSharp as it's a bit better way of doing things then working with some .exe's.
private ReadOnlyCollection<string> ExtractArchive(string varPathToFile, string varDestinationDirectory) {
ReadOnlyCollection<string> readOnlyArchiveFilenames;
ReadOnlyCollection<string> readOnlyVolumeFilenames;
varExtractionFinished = false;
varExtractionFailed = false;
SevenZipExtractor.SetLibraryPath(sevenZipDll);
string fileName = "";
string directory = "";
Invoke(new SetNoArgsDelegate(() => {
fileName = varPathToFile;
directory = varDestinationDirectory;
}));
using (SevenZipExtractor extr = new SevenZipExtractor(fileName)) {
//string[] test = extr.ArchiveFileNames.
readOnlyArchiveFilenames = extr.ArchiveFileNames;
readOnlyVolumeFilenames = extr.VolumeFileNames;
//foreach (string dinosaur in readOnlyDinosaurs) {
//MessageBox.Show(dinosaur);
// }
//foreach (string dinosaur in readOnlyDinosaurs1) {
// // MessageBox.Show(dinosaur);
// }
try {
extr.Extracting += extr_Extracting;
extr.FileExtractionStarted += extr_FileExtractionStarted;
extr.FileExists += extr_FileExists;
extr.ExtractionFinished += extr_ExtractionFinished;
extr.ExtractArchive(directory);
} catch (FileNotFoundException error) {
if (varExtractionCancel) {
LogBoxTextAdd("[EXTRACTION WAS CANCELED]");
} else {
MessageBox.Show(error.ToString(), "Error with extraction");
varExtractionFailed = true;
}
}
}
varExtractionFinished = true;
return readOnlyVolumeFilenames;
}
private void extr_FileExists(object sender, FileOverwriteEventArgs e) {
listViewLogFile.Invoke(new SetOverwriteDelegate((args) => LogBoxTextAdd(String.Format("Warning: \"{0}\" already exists; overwritten\r\n", args.FileName))), e);
}
private void extr_FileExtractionStarted(object sender, FileInfoEventArgs e) {
listViewLogFile.Invoke(new SetInfoDelegate((args) => LogBoxTextAdd(String.Format("Extracting \"{0}\"", args.FileInfo.FileName))), e);
}
private void extr_Extracting(object sender, ProgressEventArgs e) {
progressBarCurrentExtract.Invoke(new SetProgressDelegate((args) => progressBarCurrentExtract.Increment(args.PercentDelta)), e);
}
private void extr_ExtractionFinished(object sender, EventArgs e) {
Invoke(new SetNoArgsDelegate(() => {
//pb_ExtractWork.Style = ProgressBarStyle.Blocks;
progressBarCurrentExtract.Value = 0;
varExtractionFinished = true;
//l_ExtractProgress.Text = "Finished";
}));
}
Of course you need to adjust things a bit, and use some of your own stuff. But for the sake of example I've added some additional methods.
You might skip the middle step and call the winrar.exe with the parameters straight instead of first instanciating cmd.exe
Also you might take a look at the 7-zip SDK
UnRar("C:\\Download\\sampleextractfolder\\", filepath2);
private static void UnRar(string WorkingDirectory, string filepath)
{
// Microsoft.Win32 and System.Diagnostics namespaces are imported
//Dim objRegKey As RegistryKey
RegistryKey objRegKey;
objRegKey = Registry.ClassesRoot.OpenSubKey("WinRAR\\Shell\\Open\\Command");
// Windows 7 Registry entry for WinRAR Open Command
// Dim obj As Object = objRegKey.GetValue("");
Object obj = objRegKey.GetValue("");
//Dim objRarPath As String = obj.ToString()
string objRarPath = obj.ToString();
objRarPath = objRarPath.Substring(1, objRarPath.Length - 7);
objRegKey.Close();
//Dim objArguments As String
string objArguments;
// in the following format
// " X G:\Downloads\samplefile.rar G:\Downloads\sampleextractfolder\"
objArguments = " X " + " " + filepath + " " + " " + WorkingDirectory;
// Dim objStartInfo As New ProcessStartInfo()
ProcessStartInfo objStartInfo = new ProcessStartInfo();
// Set the UseShellExecute property of StartInfo object to FALSE
//Otherwise the we can get the following error message
//The Process object must have the UseShellExecute property set to false in order to use environment variables.
objStartInfo.UseShellExecute = false;
objStartInfo.FileName = objRarPath;
objStartInfo.Arguments = objArguments;
objStartInfo.WindowStyle = ProcessWindowStyle.Hidden;
objStartInfo.WorkingDirectory = WorkingDirectory + "\\";
// Dim objProcess As New Process()
Process objProcess = new Process();
objProcess.StartInfo = objStartInfo;
objProcess.Start();
objProcess.WaitForExit();
try
{
FileInfo file = new FileInfo(filepath);
file.Delete();
}
catch (FileNotFoundException e)
{
throw e;
}
}
You forgot to add a stream for reading errors. If WINRAR is behaving properly, you will find your error output when you add the stream to read it.
I Got the answer.
try this one:
System.Diagnostics.Process proc = new System.Diagnostics.Process();
//Put the path of installed winrar.exe
proc.StartInfo.FileName = @"C:\Program Files\WinRAR\unrar.exe";
proc.StartInfo.CreateNoWindow = true;
proc.StartInfo.WindowStyle = ProcessWindowStyle.Hidden;
proc.EnableRaisingEvents = true;
//PWD: Password if the file has any
//SRC: The path of your rar file. e.g: c:\temp\abc.rar
//DES: The path you want it to be extracted. e.g: d:\extracted
//ATTENTION: DESTINATION FOLDER MUST EXIST!
proc.StartInfo.Arguments = String.Format("x -p{0} {1} {2}", PWD, SRC, DES);
proc.Start();
As Kjartan suggested, using 7-Zip SDK may be a better option than spawning an external executable depending on your use:
7-Zip SDK is a C/C++ library but http://sevenzipsharp.codeplex.com/ has a .Net library of it around the 7-Zip SDK which makes it easier to use in .NET.
We can also use this,
string SourceFile = @"G:\SourceFolder\125.rar";
string DestinationPath = @"G:\Destination\";
System.Diagnostics.Process process = new System.Diagnostics.Process();
process.StartInfo.FileName = @"G:\Software\WinRAR.exe";
process.StartInfo.CreateNoWindow = true;
process.StartInfo.WindowStyle = ProcessWindowStyle.Hidden;
process.EnableRaisingEvents = false;
process.StartInfo.Arguments = string.Format("x -o+ \"{0}\" \"{1}\"", SourceFile, DestinationPath);
process.Start();
9 Answers, only sam mousavi is answering your question directly, but noone's telling you what's wrong. Citing from the WinRAR manual:
...the command: WinRAR x Fonts *.ttf NewFonts\
will extract *.ttf files from the archive Fonts to the folder NewFonts
You need to use the trailing backslash as in the example above for denoting the destination folder.
And that's exactly what's missing up there at c:\download. Right now it tries to extract the file c:\download inside the archive to the current directory. How it could work the first time is a mystery.
You can use this lib directly: http://sevenziplib.codeplex.com/
SevenZipLib is a lightweight, easy-to-use managed interface to the 7-zip library.
