可以将文章内容翻译成中文,广告屏蔽插件可能会导致该功能失效(如失效,请关闭广告屏蔽插件后再试):
问题:
I have a method to validate a parameter IP Address. Being new to development as a whole I would like to know if there is a better way of doing this.
/// <summary>
/// Check IP Address, will accept 0.0.0.0 as a valid IP
/// </summary>
/// <param name="strIP"></param>
/// <returns></returns>
public Boolean CheckIPValid(String strIP)
{
// Split string by ".", check that array length is 3
char chrFullStop = '.';
string[] arrOctets = strIP.Split(chrFullStop);
if (arrOctets.Length != 4)
{
return false;
}
// Check each substring checking that the int value is less than 255 and that is char[] length is !> 2
Int16 MAXVALUE = 255;
Int32 temp; // Parse returns Int32
foreach (String strOctet in arrOctets)
{
if (strOctet.Length > 3)
{
return false;
}
temp = int.Parse(strOctet);
if (temp > MAXVALUE)
{
return false;
}
}
return true;
}
Its simple (I could do it) but it seems to do the trick.
回答1:
The limitation with IPAddress.TryParse
method is that it verifies if a string could be converted to IP address, thus if it is supplied with a string value like "5"
, it consider it as "0.0.0.5"
.
Another approach to validate an IPv4 could be following :
public bool ValidateIPv4(string ipString)
{
if (String.IsNullOrWhiteSpace(ipString))
{
return false;
}
string[] splitValues = ipString.Split('.');
if (splitValues.Length != 4)
{
return false;
}
byte tempForParsing;
return splitValues.All(r => byte.TryParse(r, out tempForParsing));
}
It could be tested like:
List<string> ipAddresses = new List<string>
{
"2",
"1.2.3",
"1.2.3.4",
"255.256.267.300",
"127.0.0.1",
};
foreach (var ip in ipAddresses)
{
Console.WriteLine($"{ip} ==> {ValidateIPv4(ip)}");
}
The output will be:
2 ==> False
1.2.3 ==> False
1.2.3.4 ==> True
255.256.267.300 ==> False
127.0.0.1 ==> True
You can also use IPAddress.TryParse
but it has the limitations and could result in incorrect parsing.
System.Net.IPAddress.TryParse Method
Note that TryParse returns true if it parsed the input successfully,
but that this does not necessarily mean that the resulting IP address
is a valid one. Do not use this method to validate IP addresses.
But this would work with normal string containing at least three dots. Something like:
string addrString = "192.168.0.1";
IPAddress address;
if (IPAddress.TryParse(addrString, out address)) {
//Valid IP, with address containing the IP
} else {
//Invalid IP
}
With IPAddress.TryParse
you can check for existence of three dots and then call TryParse
like:
public static bool ValidateIPv4(string ipString)
{
if (ipString.Count(c => c == '.') != 3) return false;
IPAddress address;
return IPAddress.TryParse(ipString, out address);
}
回答2:
using System.Net;
public static bool CheckIPValid(string strIP)
{
IPAddress result = null;
return
!String.IsNullOrEmpty(strIP) &&
IPAddress.TryParse(strIP, out result);
}
and you're done
Edit 1
Added some additional checks to prevent exceptions being thrown (which are costly). PS it won't handle unicode.
Edit 2
@StephenMurby IPAddress.TryParse
will return true if it successfully parsed the string. If you check the documentation for the method though it will throw an exception in two cases.
- The string is null.
- The string contains unicode characters.
Its up to you to decide (design decision) whether you want to throw exceptions or return false. When it comes to parsing I generally prefer to return false rather than exceptions (the assumption being this is input that's not guaranteed to be correct).
Breaking the return statement down, I am saying,
- The string is not null (nor empty which won't parse anyway) AND
- The IP address parses correctly.
Remember C# boolean expressions are lazy evaluated, so the CLR won't attempt to even parse the string if it is null
or empty.
About the missing if, you can do something like,
if (IP.TryParse(strIP, out result)
{
return true;
}
But all you really doing is saying if something is true, return true. Easier to just return the expression straight away.
回答3:
Why dont you use IPAddress.Parse or IPAddress.TryParse
IPAddress.Parse(stringVarialbeContainingIP)
回答4:
Without using IPAddress class and validating against byte, which is far better than the Int<256 approach.
public Boolean CheckIPValid(String strIP)
{
// Split string by ".", check that array length is 4
string[] arrOctets = strIP.Split('.');
if (arrOctets.Length != 4)
return false;
//Check each substring checking that parses to byte
byte obyte = 0;
foreach (string strOctet in arrOctets)
if (!byte.TryParse(strOctet, out obyte))
return false;
return true;
}
回答5:
The framework provides the IPAddress
class which in turn provides you the Parse
and TryParse
methods.
// myAddress is a System.Net.IPAddress instance
if (System.Net.IPAddress.TryParse(strIP , out myAddress))
// IP is valid
else
// IP isn't valid
回答6:
The best Regex solution :
^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$
C#
Regex.IsMatch(value, "^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$")
回答7:
Surprised no one offered a Regex solution. All you need is to include System.Text.RegularExpressions. For readability both in actual code and for this example, I ALWAYS chunk my regex pattern into a string array and then join it.
// Any IP Address
var Value = "192.168.0.55";
var Pattern = new string[]
{
"^", // Start of string
@"([01]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])\.", // Between 000 and 255 and "."
@"([01]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])\.",
@"([01]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])\.",
@"([01]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])", // Same as before, no period
"$", // End of string
};
// Evaluates to true
var Match = Regex.IsMatch(Value, string.Join(string.Empty, Pattern));
回答8:
You can process like that it it is either an ipv4 or ipv6:
public static string CheckIPValid(string strIP)
{
//IPAddress result = null;
//return !String.IsNullOrEmpty(strIP) && IPAddress.TryParse(strIP, out result);
IPAddress address;
if (IPAddress.TryParse(strIP, out address))
{
switch (address.AddressFamily)
{
case System.Net.Sockets.AddressFamily.InterNetwork:
// we have IPv4
return "ipv4";
//break;
case System.Net.Sockets.AddressFamily.InterNetworkV6:
// we have IPv6
return "ipv6";
//break;
default:
// umm... yeah... I'm going to need to take your red packet and...
return null;
//break;
}
}
return null;
}
回答9:
try with this:
private bool IsValidIP(String ip)
{
try
{
if (ip == null || ip.Length == 0)
{
return false;
}
String[] parts = ip.Split(new[] { "." }, StringSplitOptions.None);
if (parts.Length != 4)
{
return false;
}
foreach (String s in parts)
{
int i = Int32.Parse(s);
if ((i < 0) || (i > 255))
{
return false;
}
}
if (ip.EndsWith("."))
{
return false;
}
return true;
}
catch (Exception e)
{
return false;
}
}
回答10:
If you want to just check if is valid do only:
bool isValid = IPAddress.TryParse(stringIP, out IPAddress _);
It will valid even if this is above 255 and if have dots, so no need to check it.