i'm trying to edit the pixels of a 8bpp. Since this PixelFormat is indexed i'm aware that it uses a Color Table to map the pixel values. Even though I can edit the bitmap by converting it to 24bpp, 8bpp editing is much faster (13ms vs 3ms). But, changing each value when accessing the 8bpp bitmap results in some random rgb colors even though the PixelFormat remains 8bpp.
I'm currently developing in c# and the algorithm is as follows:
(C#)
1- Load original Bitmap at 8bpp
2- Create Empty temp Bitmap with 8bpp with the same size as the original
3-LockBits of both bitmaps and, using P/Invoke, calling c++ method where I pass the Scan0 of each BitmapData object. (I used a c++ method as it offers better performance when iterating through the Bitmap's pixels)
(C++)
4- Create a int[256] palette according to some parameters and edit the temp bitmap bytes by passing the original's pixel values through the palette.
(C#)
5- UnlockBits.
My question is how can I edit the pixel values without having the strange rgb colors, or even better, edit the 8bpp bitmap's Color Table?
There is no need to move into C++ land or use P/Invoke at all; C# supports pointers and unsafe code perfectly fine; I may even hazard a guess that this is causing your problems.
The colors are likely coming from the default Palette. You'll find that changing the Palette shouldn't be slow at all. This is what I do to create a greyscale palette:
image = new Bitmap( _size.Width, _size.Height, PixelFormat.Format8bppIndexed);
ColorPalette pal = image.Palette;
for(int i=0;i<=255;i++) {
// create greyscale color table
pal.Entries[i] = Color.FromArgb(i, i, i);
}
image.Palette = pal; // you need to re-set this property to force the new ColorPalette
Imagine that your indexed 8ppp graysacle are stored in a linear array dataB (for speed)
Try this code:
//Create 8bpp bitmap and look bitmap data
bmp = new Bitmap(width, height, PixelFormat.Format8bppIndexed);
bmp.SetResolution(horizontalResolution, verticalResolution);
bmpData = bmp.LockBits(new Rectangle(0, 0, width, height), System.Drawing.Imaging.ImageLockMode.WriteOnly, PixelFormat.Format8bppIndexed);
//Create grayscale color table
ColorPalette palette = bmp.Palette;
for (int i = 0; i < 256; i++)
palette.Entries[i] = Color.FromArgb(i, i, i);
bmp.Palette = palette;
//write data to bitmap
int dataCount = 0;
int stride = bmpData.Stride < 0 ? -bmpData.Stride : bmpData.Stride;
unsafe
{
byte* row = (byte*)bmpData.Scan0;
for (int f = 0; f < height; f++)
{
for (int w = 0; w < width; w++)
{
row[w] = (byte)Math.Min(255, Math.Max(0, dataB[dataCount]));
dataCount++;
}
row += stride;
}
}
//Unlock bitmap data
bmp.UnlockBits(bmpData);
Have you tried loading a System.Drawing.Image instead? That class gives you access to the colour palette. You can then wrap the System.Drawing.Image up as a System.Drawing.Bitmap once the palette is set.
I'm not sure how System.Drawing.BitMap.SetPixel() works with indexed coloured images. It could be it tries to map it to the closest colour in the palette.
