更新的MySQL纪录GET URL ID创建了一个页面上(Update MySQL record o

2019-10-20 04:52发布

我创建一个简单的报告系统,我想从数据库中生成的menues和页面。

我看到YouTube上的这个视频,并设法建立与下面的代码的菜单。

我有一个数据库表叫叫rep_id,rep_date,rep_ledit_date,rep_by,部门,职位,报告和rep_to报告和列。 而另一台调用密码名为id列,用户名,密码,名字,姓氏,部门,现在的位置,和用户。

我设法以选择报告表中的一个添加的记录,但是,我有以下问题。 1. rep_to不预选已选定的选项2,记录不能用PHP通知被更新:未定义指数:rep_id在C:\瓦帕\ WWW \ CME \上线232和无更新编辑这个-report.php上的数据库。 这条线是在选择报告表请参考下面的PHP代码。

<?php
  if(isset($_SESSION['users'])) { 
      $uname = $_SESSION['users']; 
      $fname = $_SESSION['firstname'];
      $lname = $_SESSION['lastname'];
      $dep = $_SESSION['depart'];
      $pos = $_SESSION['position'];
      $query = mysqli_query($con, "SELECT * FROM users WHERE username = $uname");
      while($row = mysqli_fetch_assoc($query)) {
          $id=$row['id'];
          $fname=$row['first_name']; 
          $lname=$row['last_name'];
          $dep = $row['department']; 
          $pos = $row['position']; 
          $repby = $row['first_name'] . " " . $row['last_name']; 
          $repdep = $row['department'];
          $reppos = $row['position'];
      } 
   } 

        mysqli_select_db($con, $db_name);
        $edit= "SELECT * FROM reports WHERE rep_id = '{$_GET['rep_id']}'";
        $result = mysqli_query($con, $edit) or die(mysqli_error($con));

        $row2 =  mysqli_fetch_array($result);

  if(isset($_POST['update'])) {
      $_GET['rep_id']=$row2['rep_id'];
      $reptype = $_POST['reporttype'];
      $report = $_POST['report'];
      $repto = $_POST['reportedto'];
      $update=(mysqli_select_db($con, $db_name));
      if(!$update) {
          die('Could not connect: ' . mysql_error($con));
      }
      else {
          $sql = "UPDATE reports SET rep_type='$reptype', report='$report', rep_to='$repto',
                  rep_ledit_date=NOW() WHERE rep_id='{$_GET['rep_id']}'";
          $retval = mysqli_query($con, $sql);
          if(!$retval ) {
              $errorMessage='Could not update data: ' . mysqli_error($con);
          }
          else {
              $success="Updated data successfully\n";
              header("location:edit-this-report.php"); 
              mysqli_close($con);
          }
      }
  }

?>

和表单代码:

  <form name="editor" action="edit-this-report.php" method="post" >
   <p class="inline">
    <span>
       <label for="mem">Reported by</label>
  <input type="text" name="reportedby" maxlength="20" disabled value="<?php print  $fname . " " . $lname; ?>" />
    </span>
   </p>
   <p class="inline">
     <span>
        <label for="mem">Department Name</label><input type="text" name="repdepart" disabled size="100" maxlength="100" value="<?php print $dep; ?>">
     </span>
   </p>

   <p class="inline">
      <span>
        <label for="mem">Position</label><input disabled type="text" name="repposition" size="100" value="<?php print $pos; ?>">
      </span>
   </p>

   <p>
     <span>
      <label for="mem">Report Type</label> 
       <select name="reporttype">
          <option value=""<?php if ($row2['rep_type'] === 'Daily Report') echo ' selected="selected"'; ?>>Daily Report</option>
          <option  value=""<?php if ($row2['rep_type'] === 'Weekly Report') echo ' selected="selected"'; ?>>Weekly Report</option>
          <option value=""<?php if ($row2['rep_type'] === 'Monthly Report') echo ' selected="selected"'; ?>>Monthly Report</option>
          <option value=""<?php if ($row2['rep_type'] === 'Quarterly Report') echo ' selected="selected"'; ?>>Quarterly Report</option>
          <option value=""<?php if ($row2['rep_type'] === 'Annual Report') echo ' selected="selected"'; ?>>Annual Report</option>
          <option  value=""<?php if ($row2['rep_type'] === 'Terminal Report') echo ' selected="selected"'; ?>>Terminal Report</option>
      </select>
     <span>
   </p>

   <p>
    <span>
         <label for="mem">Report</label> 
         <textarea name="report" id="report" rows="23" cols="auto" ><?php echo $row2['report'];?></textarea>
    <span>
   </p>
   <p>
    <span>
        <label for="mem">Reported to</label> 
        <select name="reportedto">
  <?php
  require ("includes/db.php");
        $q2= "SELECT * FROM users WHERE department like '%$repdep%'"; 
        $result3=mysqli_query($con, $q2) or die(mysqli_error($con));
        while ($getuser=mysqli_fetch_array($result3)){
        $repto=$getuser['first_name'] . " " . $getuser['last_name'];
  ?>
          <option value="<?php echo $repto; ?>"><?php echo $repto; ?></option>; 
        <?php       
        }       
        ?>

        </select>

    </span>
   </p>
    <span>
        <input name="update" type="submit" class="btn btn-large btn-primary" id="report_button" value="Submit Report" > 
        <input name="cancel" type="reset" class="btn btn-large btn-secondary" id="report_button" value="Cancel All Changes" >
    </span>
   </p>
  </form>

请帮我在这。

谢谢!

Answer 1:

我没有看到一个rep_id表单中的变量设置,所以提交表单,当你没有得到回该值。 你依靠$ _GET在前面的查询,为您提供更新的rep_id [“rep_id”],但我看到你的表格没有提供$ _GET瓦尔。 (也许不是最好的做法混合POST和GET,更好的是添加一个隐藏的表单变种,并将其设置rep_id ,并捕捉,作为一个POST变种。)

尽管如此,我能想到的,使你的代码工作的最简单的方法是将rep_id追加到表单action属性:

<form name="editor" action="edit-this-report.php?rep_id=<?php echo $_GET['rep_id']; ?>" method="post" >

运行,如果你得到任何更多的错误汇报。

另外一个问题,虽然可能不是一个表明,塞,在这之前的SELECT * FROM users查询中,$ UNAME VAR没有加引号。 更大,未来的问题虽然是在SQL语句中使用不安全的,用户提供的或黑客可以操纵的变量,让你的数据库打开SQL注入攻击。

更新:

考虑是这样的:

<?php

session_start();

require ('includes/db.php'); // provides $con, select database

// get logon info
if ( !isset($_SESSION['username']) ) { header('Location: logon.php'); } // logon and set session vars
else {
  list($uname, $repby, $dep, $pos) = 
      array($_SESSION['username'], $_SESSION['repby'], $_SESSION['department'], $_SESSION['position']);
}

// get report id if GET'd
if ( isset($_GET['rep_id'])  ) {
    $rep_id = $_GET['rep_id'];
}

// update report if POST'd
else if ( isset($_POST['update'] ) ) {
    $rep_id  = $_POST['rep_id'];
    $reptype = $_POST['reporttype'];
    $report  = $_POST['report'];
    $repto   = $_POST['reportedto'];

    if ( mysqli_stmt_prepare($stmt, 'UPDATE reports SET rep_type= ?, report= ?, rep_to= ?, rep_ledit_date= ? WHERE rep_id= ?') ) {
        mysqli_stmt_bind_param($stmt, 'sssi', $reptype, $report, $repto, NOW(), $rep_id);
        mysqli_stmt_execute($stmt);
        mysqli_stmt_close($stmt);
    }
    else { $errorMessage='Could not update report data: ' . mysqli_error($con); }
}
else { die('no report id'); }

// get/verify report info (can be moved to get'd if to save a db call when post'd)
list($rep_type, $report) = array('', '');
$stmt = mysqli_stmt_init($con);
if ( mysqli_stmt_prepare($stmt, 'SELECT rep_id, rep_type, report FROM Reports WHERE rep_id = ?') ) {
    mysqli_stmt_bind_param($stmt, 'i', $rep_id);
    mysqli_stmt_execute($stmt);
    mysqli_stmt_bind_result($stmt, $rep_id, $rep_type, $report);
    mysqli_stmt_fetch($stmt);
    mysqli_stmt_close($stmt);
}
else { $errorMessage='Could not select report data: ' . mysqli_error($con); }

?>


 <form name="editor" action="edit-this-report.php" method="post" >
   <input type="hidden" name="rep_id" value="<?=$rep_id?>">
   <p class="inline">
    <span>
       <label for="mem">Reported by</label>
  <input type="text" name="reportedby" maxlength="20" disabled value="<?=$repby?>" />
    </span>
   </p>
   <p class="inline">
     <span>
        <label for="mem">Department Name</label><input type="text" name="repdepart" disabled size="100" maxlength="100" value="<?=$dep?>">
     </span>
   </p>

   <p class="inline">
      <span>
        <label for="mem">Position</label><input disabled type="text" name="repposition" size="100" value="<?=$pos?>">
      </span>
   </p>

   <p>
     <span>
      <label for="mem">Report Type</label> 
       <select name="reporttype">

<?php

list($rep_type_da, $rep_type_we, $rep_type_mo, $rep_type_qu, $rep_type_an, $rep_type_te) = array('', '', '', '', '', '');
switch ( $rep_type ) {
    case 'Daily Report': $rep_type_da = ' selected'; break;
    case 'Daily Report': $rep_type_we = ' selected'; break;
    case 'Daily Report': $rep_type_mo = ' selected'; break;
    case 'Daily Report': $rep_type_qu = ' selected'; break;
    case 'Daily Report': $rep_type_an = ' selected'; break;
    case 'Daily Report': $rep_type_te = ' selected'; break;
}

?>
          <option value="Daily Report"    <?=$rep_type_da?>>Daily Report</option>
          <option value="Weekly Report"   <?=$rep_type_we?>>Weekly Report</option>
          <option value="Monthly Report"  <?=$rep_type_mo?>>Monthly Report</option>
          <option value="Quarterly Report"<?=$rep_type_qu?>>Quarterly Report</option>
          <option value="Annual Report"   <?=$rep_type_an?>>Annual Report</option>
          <option value="Terminal Report" <?=$rep_type_te?>>Terminal Report</option>
      </select>
     <span>
   </p>

   <p>
    <span>
         <label for="mem">Report</label> 
         <textarea name="report" id="report" rows="23" cols="auto" ><?=$report?></textarea>
    <span>
   </p>
   <p>
    <span>
        <label for="mem">Reported to</label> 
        <select name="reportedto">
          <option value=""></option>
<?php

if ( mysqli_stmt_prepare($stmt, 'SELECT CONCAT(first_name, last_name) AS repto FROM users WHERE department LIKE ?') ) {
    mysqli_stmt_bind_param($stmt, 's', "%$dep%");
    mysqli_stmt_execute($stmt);
    mysqli_stmt_bind_result($stmt, $repto);
    while ( mysqli_stmt_fetch($stmt) ) {
        echo '<option value="' . $repto . '">' . $repto . "</option>\n";
    }
    mysqli_stmt_close($stmt);
}
else { $errorMessage='Could not select dep user data: ' . mysqli_error($con); }

?>

        </select>

    </span>
   </p>
    <span>
        <input name="update" type="submit" class="btn btn-large btn-primary" id="report_button" value="Submit Report" > 
        <input name="cancel" type="reset" class="btn btn-large btn-secondary" id="report_button" value="Cancel All Changes" >
    </span>
   </p>
  </form>

我还没有建立数据库,所以我没有测试它。 如果你运行这个并得到错误,张贴在他们的意见。



Answer 2:

你将不得不找出到底是哪上述行线232,但在PHP中“未定义指数”的错误意味着你有一个数组($ _ GET和$ _POST都是数组),并且您试图访问一个值(在这种情况下,中,所述一个:$ _GET [“rep_id”] = 1;),但它不能找到数组中的“索引”(在这种情况下“rep_id”)。

某处你访问一个尚未在页面上定义通过索引数组元素。

编辑:这里大概:$编辑= “SELECT * FROM报告WHERE rep_id = '{$ _GET [' rep_id ']}'”;

$ _GET被引用称为rep_id网址变数,但你不用交送rep_id? 在这种情况下,尝试改变$ _GET [ 'rep_id']到$ _ POST [ 'rep_id']



Answer 3:

除了由bloodyKnuckles给出的解决方案,我还接到了一个朋友的帮助。 还有一个在下面后的数值给出初始值的问题if(isset($_POST['update']))

  <?php
  if(isset($_SESSION['users'])) { 
      $uname = $_SESSION['users']; 
      $fname = $_SESSION['firstname'];
      $lname = $_SESSION['lastname'];
      $dep = $_SESSION['depart'];
      $pos = $_SESSION['position'];
      $query = mysqli_query($con, "SELECT * FROM users WHERE username = $uname");
      while($row = mysqli_fetch_assoc($query)) {
          $id=$row['id'];
          $fname=$row['first_name']; 
          $lname=$row['last_name'];
          $dep = $row['department']; 
          $pos = $row['position']; 
          $repby = $row['first_name'] . " " . $row['last_name']; 
          $repdep = $row['department'];
          $reppos = $row['position'];
      } 
   } 
  mysqli_select_db($con, $db_name);
  $edit= "SELECT * FROM reports WHERE rep_id = '{$_GET['rep_id']}'";
  $result = mysqli_query($con, $edit) or die(mysqli_error($con));
  $row2 =  mysqli_fetch_array($result);

  if(isset($_POST['update'])) {
      $repid = $_POST['repid'];
      $reporttype = $_POST['reporttype'];
      $report = $_POST['report'];
      $repto = $_POST['reportedto'];
      $sql = "UPDATE reports SET rep_type='$reporttype', report='$report', rep_to='$repto', rep_ledit_date=NOW() WHERE rep_id='$repid'";
      $retval = mysqli_query($con, $sql);
      mysqli_close($con);
      $success="You have successfully edited your report.";
  }

  ?>

然后在表格上,没有设置reptype值。 我还添加了一个隐藏字段,检索rep_id。

  <form name="editor" action="edit-this-report.php?rep_id=<?php echo $_GET['rep_id']; ?>" method="post" >
   <p class="inline">
    <span>
       <label for="mem">Reported by</label>
  <input type="text" name="reportedby" maxlength="20" disabled value="<?php print  $fname . " " . $lname; ?>" />
    </span>
   </p>
   <p class="inline">
     <span>
        <label for="mem">Department Name</label><input type="text" name="repdepart" disabled size="100" maxlength="100" value="<?php print $dep; ?>">
     </span>
   </p>
   <p class="inline">
      <span>
        <label for="mem">Position</label><input disabled type="text" name="repposition" size="100" value="<?php print $pos; ?>">
      </span>
   </p>
  <input name="repid" type="hidden" id="repid" value="<?php echo $row2['rep_id']; ?>">
   <p>
     <span>
     <select name="reporttype">
         <option value="Daily Report"<?php if ($row2['rep_type'] === 'Daily Report') echo ' selected="selected"'; ?>>Daily Report</option>
         <option  value="Weekly Report"<?php if ($row2['rep_type'] === 'Weekly Report') echo ' selected="selected"'; ?>>Weekly Report</option>
         <option value="Monthly Report"<?php if ($row2['rep_type'] === 'Monthly Report') echo ' selected="selected"'; ?>>Monthly Report</option>
         <option value="Quarterly Report"<?php if ($row2['rep_type'] === 'Quarterly Report') echo ' selected="selected"'; ?>>Quarterly Report</option>
         <option value="Annual Report"<?php if ($row2['rep_type'] === 'Annual Report') echo ' selected="selected"'; ?>>Annual Report</option>
         <option  value="Terminal Report"<?php if ($row2['rep_type'] === 'Terminal Report') echo ' selected="selected"'; ?>>Terminal Report</option>
     </select>
    <span>
   </p>

   <p>
    <span>
         <label for="mem">Report</label> 
         <textarea name="report" id="report" rows="23" cols="auto"><?php echo $row2['report'];?></textarea>
    <span>
   </p>
   <p>
    <span>
        <label for="mem">Reported to</label> 
        <select name="reportedto">
  <?php
  require ("includes/db.php");
        $q2= "SELECT * FROM users WHERE department like '%$repdep%'"; 
        $result3=mysqli_query($con, $q2) or die(mysqli_error($con));
        while ($getuser=mysqli_fetch_array($result3)){
        $repto=$getuser['first_name'] . " " . $getuser['last_name'];
  ?>
          <option value="<?php echo $repto; ?>"><?php echo $repto; ?></option>; 
        <?php       
        }       
        ?>

        </select>
    </span>
   </p>
    <span>
        <input name="update" type="submit" class="btn btn-large btn-primary" id="report_button" value="Submit Report" > 
        <input name="cancel" type="reset" class="btn btn-large btn-secondary" id="report_button" value="Cancel All Changes" >
    </span>
  </form>
   </p>

我希望这可以帮助其他游客。 谢谢bloodyKnuckles和马克的帮助!



文章来源: Update MySQL record on a page created with GET url ID