camera.takePicture null pointer exception

问题:

I always get a NullPointerException when I try to take a picture using this code. It always fails at camera.takePicture.

I tried to google the issue and didnt find anything. Any help would be appreciated.

Here is the code

import android.annotation.TargetApi;
import android.app.Activity;
import android.content.pm.PackageManager;
import android.hardware.Camera;
import android.hardware.Camera.CameraInfo;
import android.os.Build;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.widget.Toast;


@TargetApi(Build.VERSION_CODES.GINGERBREAD)
public class CameraService extends Activity {

final static String DEBUG_TAG = "MakePhotoActivity";
  private Camera camera;
  private int cameraId = 0;

  @TargetApi(Build.VERSION_CODES.GINGERBREAD)
@Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);

    // do we have a camera?
    if (!getPackageManager()
        .hasSystemFeature(PackageManager.FEATURE_CAMERA)) {
      Toast.makeText(this, "No camera on this device", Toast.LENGTH_LONG)
          .show();
    } else {
      cameraId = findFrontFacingCamera();
      if (cameraId < 0) {
        Toast.makeText(this, "No front facing camera found.",
            Toast.LENGTH_LONG).show();
      } else {
        camera = Camera.open(cameraId);
      }
    }
  }

  public void onClick(View view) {
    camera.takePicture(null, null,
        new PhotoHandler(getApplicationContext()));
  }

  private int findFrontFacingCamera() {
    int cameraId = -1;
    // Search for the front facing camera
    int numberOfCameras = Camera.getNumberOfCameras();
    for (int i = 0; i < numberOfCameras; i++) {
      CameraInfo info = new CameraInfo();
      Camera.getCameraInfo(i, info);
      if (info.facing == CameraInfo.CAMERA_FACING_FRONT) {
        Log.d(DEBUG_TAG, "Camera found");
        cameraId = i;
        break;
      }
    }
    return cameraId;
  }

  @Override
  protected void onPause() {
    if (camera != null) {
      camera.release();
      camera = null;
    }
    super.onPause();
  }

}

Code for PhotoHandler

import java.io.File;
import java.io.FileOutputStream;
import java.text.SimpleDateFormat;
import java.util.Date;

import android.content.Context;
import android.hardware.Camera;
import android.hardware.Camera.PictureCallback;
import android.os.Environment;
import android.util.Log;
import android.widget.Toast;

public class PhotoHandler implements PictureCallback{

private final Context context;

  public PhotoHandler(Context context) {
    this.context = context;
  }

  @Override
  public void onPictureTaken(byte[] data, Camera camera) {

    File pictureFileDir = getDir();

    if (!pictureFileDir.exists() && !pictureFileDir.mkdirs()) {

      Log.d(CameraService.DEBUG_TAG, "Can't create directory to save image.");
      Toast.makeText(context, "Can't create directory to save image.",
          Toast.LENGTH_LONG).show();
      return;

    }

    SimpleDateFormat dateFormat = new SimpleDateFormat("yyyymmddhhmmss");
    String date = dateFormat.format(new Date());
    String photoFile = "Picture_" + date + ".jpg";

    String filename = pictureFileDir.getPath() + File.separator + photoFile;

    File pictureFile = new File(filename);

    try {
      FileOutputStream fos = new FileOutputStream(pictureFile);
      fos.write(data);
      fos.close();
      Toast.makeText(context, "New Image saved:" + photoFile,
          Toast.LENGTH_LONG).show();
    } catch (Exception error) {
      Log.d(CameraService.DEBUG_TAG, "File" + filename + "not saved: "
          + error.getMessage());
      Toast.makeText(context, "Image could not be saved.",
          Toast.LENGTH_LONG).show();
    }
  }

  private File getDir() {
    File sdDir = Environment
      .getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES);
    return new File(sdDir, "CameraAPIDemo");
  }
}

The logcat output

04-15 18:24:42.316: E/AndroidRuntime(23331): FATAL EXCEPTION: main
04-15 18:24:42.316: E/AndroidRuntime(23331): java.lang.IllegalStateException: Could not execute method of the activity
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.view.View$1.onClick(View.java:3599)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.view.View.performClick(View.java:4204)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.view.View$PerformClick.run(View.java:17355)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.os.Handler.handleCallback(Handler.java:725)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.os.Handler.dispatchMessage(Handler.java:92)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.os.Looper.loop(Looper.java:137)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.app.ActivityThread.main(ActivityThread.java:5041)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at java.lang.reflect.Method.invokeNative(Native Method)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at java.lang.reflect.Method.invoke(Method.java:511)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:793)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:560)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at dalvik.system.NativeStart.main(Native Method)
04-15 18:24:42.316: E/AndroidRuntime(23331): Caused by: java.lang.reflect.InvocationTargetException
04-15 18:24:42.316: E/AndroidRuntime(23331):    at java.lang.reflect.Method.invokeNative(Native Method)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at java.lang.reflect.Method.invoke(Method.java:511)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.view.View$1.onClick(View.java:3594)
04-15 18:24:42.316: E/AndroidRuntime(23331):    ... 11 more
04-15 18:24:42.316: E/AndroidRuntime(23331): Caused by: java.lang.RuntimeException: takePicture failed
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.hardware.Camera.native_takePicture(Native Method)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.hardware.Camera.takePicture(Camera.java:1095)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at android.hardware.Camera.takePicture(Camera.java:1040)
04-15 18:24:42.316: E/AndroidRuntime(23331):    at com.egnoita.ignoramus.CameraService.onClick(CameraService.java:50)
04-15 18:24:42.316: E/AndroidRuntime(23331):    ... 14 more

回答1:

I got the same compatibility issue between 2.3 and 4.0. Here I assumed you called startPreview() before you call takePicture().

Please see my code below, it works for me both 2.3 and 4.0 devices.

PictureCallback mJpegCallback;
SurfaceView surfaceViewDummy;
Camera mCamera;
mCamera = Camera.open();
try {

    // Important here!!! If use below line under 2.3 works,
    // but not work on 4.0! Will always got 
    // java.lang.RuntimeException: takePicture failed
    // Under 4.0 must create a real SurfaceView object on the screen!

    //surfaceViewDummy = new SurfaceView(this);
    surfaceViewDummy = (SurfaceView) findViewById(R.id.surfaceView1);

    mCamera.setPreviewDisplay(surfaceViewDummy.getHolder());
    mCamera.startPreview();
} catch (Exception e) {

    Log.d("", "Start preview error " + e.toString());
}

mJpegCallback = new PictureCallback() {

    public void onPictureTaken(byte[] data, Camera camera) {
        Log.d("", "Got picture data");
        // Save the picture data by yourself
        // ...
    }
};

mCamera.takePicture(null, null, mJpegCallback);

回答2:

I think camera is null in your onClick() function because there is no guaranteed path in onCreate() to create the camera.

Modify onClick() as follows:

public void onClick(View view) {
    if(camera == null) {
        // Warn user that camera is not available via "Toast" or similar.
    } else {
        camera.takePicture(null, null,
            new PhotoHandler(getApplicationContext()));
    }
}

回答3:

Do your application permission to use the Camera?

<uses-permission android:name="android.permission.CAMERA"/>

回答4:

Try to add this to your manifest file

<uses-feature android:name="android.hardware.camera"/>

This will tell the device that the app uses the camera For more information http://developer.android.com/guide/topics/media/camera.html

回答5:

I am using the same code as yours in my application and my app too used to throw null pointer exception on the line :

camera.takePicture(null, null,new PhotoHandler(getApplicationContext()));

I think this is caused due to the camera getting a null value.To avoid this exception I put a check on top of this line of code.So that the onClick function looks like :

public void onClick(View view) {
  if (camera != null) {
    Log.d("camera state","camera is NOT null");  
  }else{
    Log.d("camera state","camera is null");
    camera = android.hardware.Camera.open(cameraId);
  }
  camera.takePicture(null, null,new PhotoHandler(getApplicationContext()));
}

Hope it helps !

回答6:

Long time since you posted the query, but the problem is that you have to start the preview before calling takePicture API, that is

 public void onClick(View view) {
camera.startPreview(); //Add this line
camera.takePicture(null, null,
    new PhotoHandler(getApplicationContext()));
}

I too am using the same code. Also note that unless you have a front camera, this will not let you to click a picture. If you just want to take a picture using the camera hardware, check for the back camera instead of the front camera.

回答7:

You said NullPointerException on calling takePicture, so my guess the error is in the call itself and not in PhotoHandler. We need LogCat to verify.

I think the culprit is: new PhotoHandler(getApplicationContext(). You should create the PhotoHandler before calling takePicture, and use its value in the takePicture function.

PhotoHandler mPhotoHandler = null;
public void onClick (View view) {
    mPhotoHandler = new PhotoHandler(getApplicationContext());
    camera.takePicture(null, null, mPhotoHandler);
}