Are booleans as method arguments unacceptable? [cl

问题:

A colleague of mine states that booleans as method arguments are not acceptable. They shall be replaced by enumerations. At first I did not see any benefit, but he gave me an example.

What's easier to understand?

file.writeData( data, true );

Or

enum WriteMode {
  Append,
  Overwrite
};

file.writeData( data, Append );

Now I got it! ;-)
This is definitely an example where an enumeration as second parameter makes the code much more readable.

So, what's your opinion on this topic?

回答1:

Boolean's represent "yes/no" choices. If you want to represent a "yes/no", then use a boolean, it should be self-explanatory.

But if it's a choice between two options, neither of which is clearly yes or no, then an enum can sometimes be more readable.

回答2:

Enums also allow for future modifications, where you now want a third choice (or more).

回答3:

Use the one that best models your problem. In the example you give, the enum is a better choice. However, there would be other times when a boolean is better. Which makes more sense to you:

lock.setIsLocked(True);

or

enum LockState { Locked, Unlocked };
lock.setLockState(Locked);

In this case, I might choose the boolean option since I think it's quite clear and unambiguous, and I'm pretty sure my lock is not going to have more than two states. Still, the second choice is valid, but unnecessarily complicated, IMHO.

回答4:

I think you almost answered this yourself, I think the end aim is to make the code more readable, and in this case the enum did that, IMO its always best to look at the end aim rather than blanket rules, maybe think of it more as a guideline i.e. enums are often more readable in code than generic bools, ints etc but there will always be exceptions to the rule.

回答5:

Remember the question Adlai Stevenson posed to ambassador Zorin at the U.N. during the cuban missile crisis?

"You are in the courtroom of world opinion right now, and you can answer yes or no. You have denied that [the missiles] exist, and I want to know whether I have understood you correctly.... I am prepared to wait for my answer until hell freezes over, if that's your decision."

If the flag you have in your method is of such a nature that you can pin it down to a binary decision, and that decision will never turn into a three-way or n-way decision, go for boolean. Indications: your flag is called isXXX.

Don't make it boolean in case of something that is a mode switch. There is always one more mode than you thought of when writing the method in the first place.

The one-more-mode dilemma has e.g. haunted Unix, where the possible permission modes a file or directory can have today result in weird double meanings of modes depending on file type, ownership etc.

回答6:

To me, neither using boolean nor enumeration is a good approach. Robert C. Martin captures this very clearly in his Clean Code Tip #12: Eliminate Boolean Arguments:

Boolean arguments loudly declare that the function does more than one thing. They are confusing and should be eliminated.

If a method does more than one thing, you should rather write two different methods, for example in your case: file.append(data) and file.overwrite(data).

Using an enumeration doesn't make things clearer. It doesn't change anything, it's still a flag argument.

回答7:

There are two reasons I've run into this being a bad thing:

1. Because some people will write methods like:

   ProcessBatch(true, false, false, true, false, false, true);
   

   This is obviously bad because it's too easy to mix up parameters, and you have no idea by looking at it what you're specifying. Just one bool isn't too bad though.

2. Because controlling program flow by a simple yes/no branch might mean you have two entirely different functions that are wrapped up into one in an awkard way. For instance:

   public void Write(bool toOptical);
   

   Really, this should be two methods

   public void WriteOptical();
   public void WriteMagnetic();
   

   because the code in these might be entirely different; they might have to do all sorts of different error handling and validation, or maybe even have to format the outgoing data differently. You can't tell that just by using Write() or even Write(Enum.Optical) (though of course you could have either of those methods just call internal methods WriteOptical/Mag if you want).

I guess it just depends. I wouldn't make too big of a deal about it except for #1.

回答8:

Enums are better but I wouldn't call boolean params as "unacceptable". Sometimes it's just easier to throw one little boolean in and move on (think private methods etc.)

回答9:

Booleans may be OK in languages that have named parameters, like Python and Objective-C, since the name can explain what the parameter does:

file.writeData(data, overwrite=true)

or:

[file writeData:data overwrite:YES]

回答10:

I would not agree that it is a good rule. Obviously, Enum makes for a better explicit or verbose code at some instances, but as a rule it seems way over reaching.

First let me take your example: The programmers responsibility (and ability) to write good code is not really jeopardized by having a Boolean parameter. In your example the programmer could have written just as verbose code by writing:

dim append as boolean = true
file.writeData( data, append );

or I prefer more general

dim shouldAppend as boolean = true
file.writeData( data, shouldAppend );

Second: The Enum example you gave is only "better" because you are passing a CONST. Most likely in most application at least some if not most of the time parameters that are passed to functions are VARIABLES. in which case my second example (giving variables with good names) is much better and Enum would have given you little benefits.

回答11:

Enums have a definite benefit, but you should't just go replacing all your booleans with enums. There are many places where true/false is actually the best way to represent what is going on.

However, using them as method arguments is a bit suspect, simply because you can't see without digging into things what they are supposed to do, as they let you see what the true/false actually means

Properties (especially with C#3 object initializers) or keyword arguments (a la ruby or python) are a much better way to go where you'd otherwise use a boolean argument.

C# example:

var worker = new BackgroundWorker { WorkerReportsProgress = true };

Ruby example

validates_presence_of :name, :allow_nil => true

Python example

connect_to_database( persistent=true )

The only thing I can think of where a boolean method argument is the right thing to do is in java, where you don't have either properties or keyword arguments. This is one of the reasons I hate java :-(

回答12:

While it is true that in many cases enums are more readable and more extensible than booleans, an absolute rule that "booleans are not acceptable" is daft. It is inflexible and counter-productive - it does not leave room for human judgement. They're a fundamental built in type in most languages because they're useful - consider applying it to other built-in-types: saying for instance "never use an int as a parameter" would just be crazy.

This rule is just a question of style, not of potential for bugs or runtime performance. A better rule would be "prefer enums to booleans for reasons of readability".

Look at the .Net framework. Booleans are used as parameters on quite a few methods. The .Net API is not perfect, but I don't think that the use of boolean as parameters is a big problem. The tooltip always gives you the name of the parameter, and you can build this kind of guidance too - fill in your XML comments on the method parameters, they will come up in the tooltip.

I should also add that there is a case when you should clearly refactor booleans to an enumeration - when you have two or more booleans on your class, or in your method params, and not all states are valid (e.g. it's not valid to have them both set true).

For instance, if your class has properties like

public bool IsFoo
public bool IsBar

And it's an error to have both of them true at the same time, what you've actually got is three valid states, better expressed as something like:

enum FooBarType { IsFoo, IsBar, IsNeither };

回答13:

Some rules that your colleague might be better adhering to are:

• Don't be dogmatic with your design.
• Choose what fits most appropriately for the users of your code.
• Don't try to bash star-shaped pegs into every hole just because you like the shape this month!

回答14:

A Boolean would only be acceptable if you do not intend to extend the functionality of the framework. The Enum is preferred because you can extend the enum and not break previous implementations of the function call.

The other advantage of the Enum is that is easier to read.

回答15:

If the method asks a question such as:

KeepWritingData (DataAvailable());

where

bool DataAvailable()
{
    return true; //data is ALWAYS available!
}

void KeepWritingData (bool keepGoing)
{
   if (keepGoing)
   {
       ...
   }
}

boolean method arguments seem to make absolutely perfect sense.

回答16:

It depends on the method. If the method does something that is very obviously a true/false thing then it is fine, e.g. below [though not I am not saying this is the best design for this method, it's just an example of where the usage is obvious].

CommentService.SetApprovalStatus(commentId, false);

However in most cases, such as the example you mention, it is better to use an enumeration. There are many examples in the .NET Framework itself where this convention is not followed, but that is because they introduced this design guideline fairly late on in the cycle.

回答17:

It does make things a bit more explicit, but does start to massively extend the complexity of your interfaces - in a sheer boolean choice such as appending/overwriting it seems like overkill. If you need to add a further option (which I can't think of in this case), you can always perform a refactor (depending on the language)

回答18:

Enums can certainly make the code more readable. There are still a few things to watch out for (in .net at least)

Because the underlying storage of an enum is an int, the default value will be zero, so you should make sure that 0 is a sensible default. (E.g. structs have all fields set to zero when created, so there's no way to specify a default other than 0. If you don't have a 0 value, you can't even test the enum without casting to int, which would be bad style.)

If your enum's are private to your code (never exposed publicly) then you can stop reading here.

If your enums are published in any way to external code and/or are saved outside of the program, consider numbering them explicitly. The compiler automatically numbers them from 0, but if you rearrange your enums without giving them values you can end up with defects.

I can legally write

WriteMode illegalButWorks = (WriteMode)1000000;
file.Write( data, illegalButWorks );

To combat this, any code that consumes an enum that you can't be certain of (e.g. public API) needs to check if the enum is valid. You do this via

if (!Enum.IsDefined(typeof(WriteMode), userValue))
    throw new ArgumentException("userValue");

The only caveat of Enum.IsDefined is that it uses reflection and is slower. It also suffers a versioning issue. If you need to check the enum value often, you would be better off the following:

public static bool CheckWriteModeEnumValue(WriteMode writeMode)
{
  switch( writeMode )
  {
    case WriteMode.Append:
    case WriteMode.OverWrite:
      break;
    default:
      Debug.Assert(false, "The WriteMode '" + writeMode + "' is not valid.");
      return false;
  }
  return true;
}

The versioning issue is that old code may only know how to handle the 2 enums you have. If you add a third value, Enum.IsDefined will be true, but the old code can't necessarily handle it. Whoops.

There's even more fun you can do with [Flags] enums, and the validation code for that is slightly different.

I'll also note that for portability, you should use call ToString() on the enum, and use Enum.Parse() when reading them back in. Both ToString() and Enum.Parse() can handle [Flags] enum's as well, so there's no reason not to use them. Mind you, it's yet another pitfall, because now you can't even change the name of the enum without possibly breaking code.

So, sometimes you need to weigh all of the above in when you ask yourself Can I get away with just an bool?

回答19:

IMHO it seems like an enum would be the obvious choice for any situation where more than two options are possible. But there definitely ARE situations where a boolean is all you need. In that case I would say that using an enum where a bool would work would be an example of using 7 words when 4 will do.

回答20:

Booleans make sense when you have an obvious toggle which can only be one of two things (i.e. the state of a light bulb, on or off). Other than that, it's good to write it in such a way that it's obvious what you're passing - e.g. disk writes - unbuffered, line-buffered, or synchronous - should be passed as such. Even if you don't want to allow synchronous writes now (and so you're limited to two options), it's worth considering making them more verbose for the purposes of knowing what they do at first glance.

That said, you can also use False and True (boolean 0 and 1) and then if you need more values later, expand the function out to support user-defined values (say, 2 and 3), and your old 0/1 values will port over nicely, so your code ought not to break.

回答21:

Sometimes it's just simpler to model different behaviour with overloads. To continue from your example would be:

file.appendData( data );  
file.overwriteData( data );

This approach degrades if you have multiple parameters, each allowing a fixed set of options. For example, a method that opens a file might have several permutations of file mode (open/create), file access (read/write), sharing mode (none/read/write). The total number of configurations is equal to the Cartesian products of the individual options. Naturally in such cases multiple overloads are not appropriate.

Enums can, in some cases make code more readable, although validating the exact enum value in some languages (C# for example) can be difficult.

Often a boolean parameter is appended to the list of parameters as a new overload. One example in .NET is:

Enum.Parse(str);  
Enum.Parse(str, true); // ignore case

The latter overload became available in a later version of the .NET framework than the first.

If you know that there will only ever be two choices, a boolean might be fine. Enums are extensible in a way that won't break old code, although old libraries might not support new enum values so versioning cannot be completely disregarded.

---

EDIT

In newer versions of C# it's possible to use named arguments which, IMO, can make calling code clearer in the same way that enums can. Using the same example as above:

Enum.Parse(str, ignoreCase: true);

回答22:

Where I do agree that Enums are good way to go, in methods where you have 2 options (and just two options you can have readability without enum.)

e.g.

public void writeData(Stream data, boolean is_overwrite)

Love the Enums, but boolean is useful too.

回答23:

This is a late entry on an old post, and it's so far down the page that nobody will ever read it, but since nobody has said it already....

An inline comment goes a long way to solving the unexpected bool problem. The original example is particularly heinous: imagine trying to name the variable in the function declearation! It'd be something like

void writeData( DataObject data, bool use_append_mode );

But, for the sake of example, let's say that's the declaration. Then, for an otherwise unexplained boolean argument, I put the variable name in an inline comment. Compare

file.writeData( data, true );

with

file.writeData( data, true /* use_append_mode */);

回答24:

It really depends on the exact nature of the argument. If it is not a yes/no or true/false then a enum makes it more readable. But with an enum you need to check the argument or have acceptable default behaviour since undefined values of the underlying type can be passed.

回答25:

The use of enums instead of booleans in your example does help make the method call more readable. However, this is a substitute for my favorite wish item in C#, named arguments in method calls. This syntax:

var v = CallMethod(pData = data, pFileMode = WriteMode, pIsDirty = true);

would be perfectly readable, and you could then do what a programmer should do, which is choose the most appropriate type for each parameter in the method without regard to how it looks in the IDE.

C# 3.0 allows named arguments in constructors. I don't know why they can't do this with methods as well.

回答26:

Booleans values true/false only. So it is not clear what it represent. Enum can have meaningful name, e.g OVERWRITE, APPEND, etc. So enums are better.