With C# 6 I can write:
public class Person
{
public Guid Id { get; }
public string Name { get; }
public Person(Guid id, string name)
{
Id = id;
Name = name;
}
}
Unfortunately a class like this is not serialized correctly by MongoDb driver, properties are not serialized.
MongoDb only serialize by default properties with getter and setter. I known that you can manually change the class mapping and tell serializer to include get-only properties but I was looking for a generic way to avoid customizing each mapping.
I was thinking to create a custom convention similar to ReadWriteMemberFinderConvention but without the CanWrite
check.
There are other solutions? Constructor will be called automatically or I need some other customization?
I have tried to solve this problem by creating a convention that map all read only properties that match a constructor and also the matched constructor.
Assume that you have an immutable class like:
public class Person
{
public string FirstName { get; }
public string LastName { get; }
public string FullName => FirstName + LastName;
public ImmutablePocoSample(string lastName)
{
LastName = lastName;
}
public ImmutablePocoSample(string firstName, string lastName)
{
FirstName = firstName;
LastName = lastName;
}
}
Here is the code of the convention:
using MongoDB.Bson.Serialization;
using MongoDB.Bson.Serialization.Conventions;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
/// <summary>
/// A convention that map all read only properties for which a matching constructor is found.
/// Also matching constructors are mapped.
/// </summary>
public class ImmutablePocoConvention : ConventionBase, IClassMapConvention
{
private readonly BindingFlags _bindingFlags;
public ImmutablePocoConvention()
: this(BindingFlags.Instance | BindingFlags.Public)
{ }
public ImmutablePocoConvention(BindingFlags bindingFlags)
{
_bindingFlags = bindingFlags | BindingFlags.DeclaredOnly;
}
public void Apply(BsonClassMap classMap)
{
var readOnlyProperties = classMap.ClassType.GetTypeInfo()
.GetProperties(_bindingFlags)
.Where(p => IsReadOnlyProperty(classMap, p))
.ToList();
foreach (var constructor in classMap.ClassType.GetConstructors())
{
// If we found a matching constructor then we map it and all the readonly properties
var matchProperties = GetMatchingProperties(constructor, readOnlyProperties);
if (matchProperties.Any())
{
// Map constructor
classMap.MapConstructor(constructor);
// Map properties
foreach (var p in matchProperties)
classMap.MapMember(p);
}
}
}
private static List<PropertyInfo> GetMatchingProperties(ConstructorInfo constructor, List<PropertyInfo> properties)
{
var matchProperties = new List<PropertyInfo>();
var ctorParameters = constructor.GetParameters();
foreach (var ctorParameter in ctorParameters)
{
var matchProperty = properties.FirstOrDefault(p => ParameterMatchProperty(ctorParameter, p));
if (matchProperty == null)
return new List<PropertyInfo>();
matchProperties.Add(matchProperty);
}
return matchProperties;
}
private static bool ParameterMatchProperty(ParameterInfo parameter, PropertyInfo property)
{
return string.Equals(property.Name, parameter.Name, System.StringComparison.InvariantCultureIgnoreCase)
&& parameter.ParameterType == property.PropertyType;
}
private static bool IsReadOnlyProperty(BsonClassMap classMap, PropertyInfo propertyInfo)
{
// we can't read
if (!propertyInfo.CanRead)
return false;
// we can write (already handled by the default convention...)
if (propertyInfo.CanWrite)
return false;
// skip indexers
if (propertyInfo.GetIndexParameters().Length != 0)
return false;
// skip overridden properties (they are already included by the base class)
var getMethodInfo = propertyInfo.GetMethod;
if (getMethodInfo.IsVirtual && getMethodInfo.GetBaseDefinition().DeclaringType != classMap.ClassType)
return false;
return true;
}
}
You can register i using:
ConventionRegistry.Register(
nameof(ImmutablePocoConvention),
new ConventionPack { new ImmutablePocoConvention() },
_ => true);
If you don't want all the read-only properties to be serialized you can add a public set doing nothing (if applicable), just note that the property will be re-evaluated when your class is de-serialized.
public class Person
{
public string FirstName { get; }
public string LastName { get; }
public string FullName
{
get
{
return FirstName + LastName;
}
set
{
//this will switch on the serialization
}
}
}